Closed
Bug 817846
Opened 12 years ago
Closed 12 years ago
Add BaseSize::IsEmpty()
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: cjones, Assigned: catalin.usurelu5)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Which means width != 0 && height != 0.
Will probably want a round of bikeshedding on this.
Can I bikeshed that "width != 0 && height != 0" does not mean IsEmpty? :)
(Did you mean "width == 0 || height == 0"?)
|
Reporter | |
Comment 2•12 years ago
|
||
I did, thanks!
|
Assignee | |
Comment 3•12 years ago
|
||
I'm not sure if I need to do anything else ...
Attachment #692659 -
Flags: review?(jones.chris.g)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #692659 -
Flags: review?(jones.chris.g) → review+
|
||
Comment 4•12 years ago
|
||
Clearing [good first bug] flag and adding checkin-needed.
Keywords: checkin-needed
Whiteboard: [good first bug]
|
||
Comment 5•12 years ago
|
||
Thanks for the patch, Usurelu! One request, to make life easier for those checking in on your behalf, please make sure that future patches follow the guidelines at the link below so that they have all the metadata needed for checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
|
|
||
Comment 6•12 years ago
|
||
Assignee: nobody → catalin.usurelu5
Keywords: checkin-needed
|
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•