Closed Bug 817919 Opened 12 years ago Closed 12 years ago

remove FM radio implementations in hal_sandbox

Categories

(Core :: Hardware Abstraction Layer (HAL), defect)

Product:
Core
Component:
Hardware Abstraction Layer (HAL)
Platform:
ARM
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20
Project Flags:
blocking-basecamp +
Tracking Flags:
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: slee, Assigned: slee)

References

Details

Attachments

(1 file, 2 obsolete files)

patch v2
(deleted), patch
slee
: review+
Details | Diff | Splinter Review 
As comment 5 in bug 814211, we should remove the permission check in sandbox.
Attached patch patch (obsolete) (deleted) — — Splinter Review 

  

  



        Attachment #688068 -
        Flags: review?(jones.chris.g)
Assignee: nobody → slee

    
    

    
  
Comment on attachment 688068 [details] [diff] [review]
patch

What we meant was just to remove the hal/sandbox impl of fm radio, since it's not used.

  

  



        Attachment #688068 -
        Flags: review?(jones.chris.g)

    
  
Summary: remove "fmradio" permission check in sandbox → remove FM radio implementations in hal_sandbox

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch V2 (obsolete) (deleted)
        — 
          — Splinter Review
      

    


  
Hi Chris,
Sorry for the wrong patch. 
I remove the implementations of FM radio in hal_sandbox. Please check this one.
Thanks.

  

  



        Attachment #688068 -
        Attachment is obsolete: true

        Attachment #688119 -
        Flags: review?(jones.chris.g)

        Attachment #688119 -
        Flags: review?(jones.chris.g) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2 (deleted)
        — 
          — Splinter Review
      

    


  
Chris, thanks for your quick review. 
Update the description in the patch.

Here is the try server log.
* try: -b do -p all -u none
** https://tbpl.mozilla.org/?tree=Try&rev=d3236d78b4c6
* try: -b d -p linux64 -u all
** https://tbpl.mozilla.org/?tree=Try&rev=19e10cbb3c87

  

  



        Attachment #688119 -
        Attachment is obsolete: true

        Attachment #688163 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
Thanks for the quick fix!

  

  


Keywords: checkin-needed
blocking-basecamp: --- → ?
blocking-basecamp: ? → +

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9c9b4cb56681

  

  


Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20

    
    

    
  
I believe this needs to be uplifted to Aurora/B2G18.

  

  


Flags: needinfo?(ryanvm)
Keywords: checkin-needed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: