Closed
Bug 817955
Opened 12 years ago
Closed 12 years ago
Identity modules are installed both under modules/ and modules/identity
Categories
(Core Graveyard :: Identity, defect)
Core Graveyard
Identity
Tracking
(firefox18 fixed, firefox19 fixed, firefox20 fixed)
RESOLVED
FIXED
mozilla20
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
patch
|
benadida
:
review+
jedp
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Most of the imports are from modules/identity, so I guess this is where they all should be.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #688142 -
Flags: review?(benadida)
Comment 2•12 years ago
|
||
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity
Review of attachment 688142 [details] [diff] [review]:
-----------------------------------------------------------------
looks good to me, checking with Jed to make sure there isn't something I'm missing.
Attachment #688142 -
Flags: review?(jparsons)
Attachment #688142 -
Flags: review?(benadida)
Attachment #688142 -
Flags: review+
Comment 3•12 years ago
|
||
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity
Looks good. Thanks for tidying this up, Mike.
Attachment #688142 -
Flags: review?(jparsons) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 6•12 years ago
|
||
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity
[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature; cleanup
User impact if declined: none
Testing completed (on m-c, etc.): manual
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none
Attachment #688142 -
Flags: approval-mozilla-beta?
Comment 7•12 years ago
|
||
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity
This needs to land on Aurora as well.
Attachment #688142 -
Flags: approval-mozilla-beta?
Attachment #688142 -
Flags: approval-mozilla-beta+
Attachment #688142 -
Flags: approval-mozilla-aurora+
Comment 8•12 years ago
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•