Closed Bug 818281 Opened 12 years ago Closed 12 years ago

Remove DOMClassInfo remnants from XMLHttpRequest

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(2 files, 1 obsolete file)

prefable: True has been removed by bug 814821.
Attached patch patch (obsolete) (deleted) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=4c3066547131 Hm, this patch caused the following regressions. Bug 763341: new XMLHttpRequest().QueryInterface(Components.interfaces.nsIClassInfo) fails (but new XMLHttpRequest().QueryInterface(Components.interfaces.nsIXMLHttpRequest) succeeds) Bug 317448, Bug 435425: new XMLHttpRequest() instanceof Components.interfaces.nsIXMLHttpRequest fails (but new XMLHttpRequest() instanceof XMLHttpRequest succeeds) Is this expected?
Blocks: 763341, 317448, 435425
Flags: needinfo?(bobbyholley+bmo)
Flags: needinfo?(bugs)
Flags: needinfo?(bzbarsky)
> new XMLHttpRequest().QueryInterface(Components.interfaces.nsIClassInfo) fails That seems fine to me. > new XMLHttpRequest() instanceof Components.interfaces.nsIXMLHttpRequest fails Ah. That's because nsJSIID::HasInstance checks for classinfo.... Peter, would it make sense to just fall back to QI there if no classinfo on a new-binding object?
Flags: needinfo?(bzbarsky)
Flags: needinfo?(peterv)
Flags: needinfo?(bobbyholley+bmo)
This part should have no side effect. https://tbpl.mozilla.org/?tree=Try&rev=9c4f69ab853b
Attachment #688486 - Attachment is obsolete: true
Attachment #688757 - Flags: review?(bzbarsky)
Comment on attachment 688757 [details] [diff] [review] Part 1: Remove legacy XHR constructor r=me
Attachment #688757 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
Whiteboard: [leave open]
Depends on: 819253
(I don't know what info was needed from me) I assume QIing in general doesn't fail.
Flags: needinfo?(bugs)
- test_wrappers.xul will need an update again when Screen is unpref'ed. But I think we should have a test until the last classinfo is removed from new-bindings objects. - test_bug317448.html has been removed because it doesn't make sense in the new-bindings world. - test_bug435425.html is now using regular constructor objects instead of SpecialPowers.Ci.nsIFoo. Try result: https://tbpl.mozilla.org/?tree=Try&rev=ff1cb49b1ff8
Attachment #690087 - Flags: review?(bzbarsky)
Attachment #688757 - Attachment description: Remove legacy XHR constructor → Part 1: Remove legacy XHR constructor
Whiteboard: [leave open] → [leave open][land part 1]
Keywords: checkin-needed
Whiteboard: [leave open][land part 1] → [leave open]
Comment on attachment 690087 [details] [diff] [review] Part 2: Remove DOMClassInfo remnants from XMLHttpRequest r=me. Thank you!
Attachment #690087 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
Whiteboard: [leave open]
Attachment #688757 - Flags: checkin+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Depends on: 842730
Flags: needinfo?(peterv)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: