Closed
Bug 818436
Opened 12 years ago
Closed 12 years ago
[toolbox] We should not be able to dock a toolbox if the target is Remote or Win
Categories
(DevTools :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: miker, Assigned: Optimizer)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
We should not be able to dock a toolbox if the target is Remote or Win
Original issue:
https://github.com/joewalker/devtools-window/issues/274
Updated•12 years ago
|
Priority: -- → P2
Updated•12 years ago
|
Assignee: nobody → scrapmachines
Assignee | ||
Comment 1•12 years ago
|
||
Do not build dock buttons, and also prevent switching in case of remote or window hosts.
Do tell if tests are required. (Not sure how to do that though yet.)
Attachment #692008 -
Flags: review?(paul)
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 692008 [details] [diff] [review]
Do not build dock buttons.
I think this needs a test. Cancelling review request for now. I will look into how to open a remote debugger and a Browser debugger to test this feature.
Attachment #692008 -
Flags: review?(paul) → feedback?(paul)
Comment 3•12 years ago
|
||
Comment on attachment 692008 [details] [diff] [review]
Do not build dock buttons.
Can you use isTab (you'll need to implement it in target.jsm)
Attachment #692008 -
Flags: feedback?(paul) → feedback-
Comment 4•12 years ago
|
||
isLocalTab is better.
Assignee | ||
Comment 5•12 years ago
|
||
Still looking into how to open remote toolbox for testing purposes. If tests are not required for such a small change, please proceed to review instead of feedback.
Attachment #692008 -
Attachment is obsolete: true
Attachment #692520 -
Flags: feedback?(paul)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [has-patch]
Updated•12 years ago
|
Attachment #692520 -
Flags: feedback?(paul) → review+
Updated•12 years ago
|
Whiteboard: [has-patch] → [land-in-fx-team]
Comment 6•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•