Closed
Bug 818442
Opened 12 years ago
Closed 12 years ago
[toolbox] Re-focus devtools window after locking the highlighter
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: miker, Assigned: paul)
Details
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
STR: - Open the DevTools and undock into a separate window. - Start the inspector - Select and element on the current page. Expected: Devtools window is raised and focused so you can start debugging the selection. Actual: Browser window remains focused. Original Github bug: https://github.com/joewalker/devtools-window/issues/239
Assignee | ||
Comment 1•12 years ago
|
||
Do we really want to do that? That would mean that every time we click on a node, we would lose the focus from the browser window and the devtools window would be raised, but you'll still have to move your mouse to reach the devtools window. I you just want to inspect a node (get information from the inspector or from the infobar), this could be very very annoying. If you want to edit the style or the markup, you'll will have to reach the window anyway.
Reporter | ||
Comment 2•12 years ago
|
||
I agree with paul. Harth, this was your bug ... what do you think?
Assignee | ||
Comment 3•12 years ago
|
||
WONTFIX. If anyone disagree, please re-open.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Comment 4•12 years ago
|
||
I still want this. The problem is that the devtools window gets lost behind the other windows. If you're using the inspector, most likely you'll want to see the styles or navigate further with the breadcrumbs after you've selected a node (at least that's what it's like for me). Right now I have to spend a distracting several seconds finding that window after I've selected my node. Also, try this: 1) Open tools 2) Select Inspector tool 3) Undock 4) Close the devtools window 5) Open tools Expected: Devtools window appears. Actual: Devtools window is opened, but inspector has focused the browser window so you don't see it, even after you've selected a node.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee | ||
Updated•12 years ago
|
Priority: -- → P2
Comment 5•12 years ago
|
||
Hacked up a trivial patch to see how it feels. This feels OK to me. Other browsers to the same.
Assignee: nobody → jwalker
Status: REOPENED → ASSIGNED
Attachment #699723 -
Flags: feedback?(paul)
Attachment #699723 -
Flags: feedback?(fayearthur)
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Joe Walker [:joe_walker] [:jwalker] from comment #5) > Created attachment 699723 [details] [diff] [review] > v1 > > Hacked up a trivial patch to see how it feels. This feels OK to me. > Other browsers to the same. We're working on the same patch at the same time :) I'm working on a broader approach.
Assignee | ||
Comment 7•12 years ago
|
||
I introduce a new function: lockAndFocus. We still need to keep the lock function because it's useful in some situations. This addresses comment 0 and comment 4.
Assignee: jwalker → paul
Attachment #699723 -
Attachment is obsolete: true
Attachment #699723 -
Flags: feedback?(paul)
Attachment #699723 -
Flags: feedback?(fayearthur)
Attachment #699757 -
Flags: review?(fayearthur)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [needs-review]
Comment 9•12 years ago
|
||
Comment on attachment 699757 [details] [diff] [review] v2 Paul, this isn't working for me on OS X. It appears to focus the devtools window but then immediately re-focus the browser window. Joe's works for me.
Attachment #699757 -
Flags: review?(fayearthur) → review-
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Heather Arthur [:harth] from comment #9) > Comment on attachment 699757 [details] [diff] [review] > v2 > > Paul, this isn't working for me on OS X. It appears to focus the devtools > window but then immediately re-focus the browser window. STR in comment 0 or comment 4? I think I know what's wrong...
Whiteboard: [needs-review]
Assignee | ||
Comment 11•12 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #10) > (In reply to Heather Arthur [:harth] from comment #9) > > Comment on attachment 699757 [details] [diff] [review] > > v2 > > > > Paul, this isn't working for me on OS X. It appears to focus the devtools > > window but then immediately re-focus the browser window. > > STR in comment 0 or comment 4? > > I think I know what's wrong... No, I don't. On Linux, it appears to work fine. Do you use the STR from comment 0?
Assignee | ||
Updated•12 years ago
|
Flags: needinfo?(fayearthur)
Comment 12•12 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #11) > (In reply to Paul Rouget [:paul] from comment #10) > > (In reply to Heather Arthur [:harth] from comment #9) > > > Comment on attachment 699757 [details] [diff] [review] > > > v2 > > > > > > Paul, this isn't working for me on OS X. It appears to focus the devtools > > > window but then immediately re-focus the browser window. > > > > STR in comment 0 or comment 4? > > > > I think I know what's wrong... > > No, I don't. On Linux, it appears to work fine. > > Do you use the STR from comment 0? Yep, using the STR.
Flags: needinfo?(fayearthur)
Comment 13•12 years ago
|
||
Comment on attachment 699757 [details] [diff] [review] v2 Review of attachment 699757 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/inspector/Highlighter.jsm @@ +295,5 @@ > if (this.locked === false) return; > this.outline.removeAttribute("locked"); > this.nodeInfo.container.removeAttribute("locked"); > this.attachMouseListeners(); > this.locked = false; We shouldn't get rid of this. Without it, it's confusing to use the highlighter on Mac.
Comment 14•12 years ago
|
||
Comment on attachment 699757 [details] [diff] [review] v2 Review of attachment 699757 [details] [diff] [review]: ----------------------------------------------------------------- Whoops, last comment was supposed to be: ::: browser/devtools/inspector/Highlighter.jsm @@ -296,5 @@ > this.outline.removeAttribute("locked"); > this.nodeInfo.container.removeAttribute("locked"); > this.attachMouseListeners(); > this.locked = false; > - this.chromeWin.focus(); We shouldn't get rid of this. Without it, it's confusing to use the highlighter on Mac.
Comment 15•12 years ago
|
||
Disregard previous two comments, I got confused. Anyways, I'm currently debugging this on Mac.
Comment 16•12 years ago
|
||
This is Paul's patch, but I removed a `win.focus()` that was re-focusing the browser window right after focusing the devtools window on Mac. I don't know the exact implications of removing that focus() call, but I found that it was added in bug 642471 and looks like it could be unnecessary now. Let me know if it works on Win/Linux.
Comment 17•12 years ago
|
||
This one adds one more modification: starting the highlighter will focus the browser window for easier selection, the original behavior regressed by the first patch.
Attachment #702145 -
Attachment is obsolete: true
Attachment #702995 -
Flags: feedback?(paul)
Updated•12 years ago
|
Assignee | ||
Comment 18•12 years ago
|
||
Comment on attachment 702995 [details] [diff] [review] Modifications 2 Delete this line: > let win = aEvent.target.ownerDocument.defaultView
Attachment #702995 -
Flags: feedback?(paul) → feedback+
Assignee | ||
Comment 19•12 years ago
|
||
Includes Heather's changes.
Attachment #699757 -
Attachment is obsolete: true
Attachment #702995 -
Attachment is obsolete: true
Attachment #703937 -
Flags: review?(fayearthur)
Comment 20•12 years ago
|
||
Comment on attachment 703937 [details] [diff] [review] v3 awesome, thanks.
Attachment #703937 -
Flags: review?(fayearthur) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 21•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6905b4296e9f
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 22•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6905b4296e9f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Updated•11 years ago
|
No longer blocks: DevToolsPaperCuts
Comment 23•10 years ago
|
||
Is this intended to not work anymore, now that the highlighter doesn't get locked anymore?
Comment 24•9 years ago
|
||
This appears to be currently broken on Windows. Anyone know if the behavious was reverted elsewhere or if it's a regression?
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•