Closed Bug 818447 Opened 12 years ago Closed 12 years ago

[toolbox] Make the "Web Developer" appmenu entry a combo button (Linux & Windows).

Categories

(DevTools :: General, defect, P2)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 20

People

(Reporter: miker, Assigned: Optimizer)

References

Details

Attachments

(1 file, 2 obsolete files)

patch v2.0
(deleted), patch
paul
: review+
Details | Diff | Splinter Review
Like the "new tab" button.
Priority: -- → P2
Assignee: nobody → scrapmachines
Do we want to remove the "Toggle Toolbox" entry after the "Web Developer" menu in app menu becomes a combo button ? As I think clicking on Web Developer would itself open the Toolbox.
Flags: needinfo?(mratcliffe)
I think we want. Let's see how it feels.
Flags: needinfo?(mratcliffe)
Attached patch Combo button (obsolete) (deleted) — — Splinter Review
Made the appmenu Web Developer entry a combo box. But now we have no information of whether a toolbox is opened for that tab through app menu.
Attachment #692462 - Flags: review?(paul)
Attached patch Combo button (obsolete) (deleted) — — Splinter Review
Made Web Developer entry a combo box in App menu. But now we have lost the way to know whether toolbox is opened for that tab via app menu.
Attachment #692462 - Attachment is obsolete: true
Attachment #692462 - Flags: review?(paul)
Attachment #692463 - Flags: review?(paul)
Blocks: 818428
Whiteboard: [has-patch]
Comment on attachment 692463 [details] [diff] [review] Combo button >- <menu id="appmenu_webDeveloper" >- label="&appMenuWebDeveloper.label;"> >+ <splitmenu id="appmenu_webDeveloper" >+ observes="devtoolsMenuBroadcaster_WebDeveloper" >+ label="&appMenuWebDeveloper.label;"> > <menupopup id="appmenu_webDeveloper_popup"> >- <menuitem id="appmenu_devToolbox" >- observes="devtoolsMenuBroadcaster_DevToolbox"/> >- <menuseparator id="appmenu_devtools_separator"/> > <menuitem id="appmenu_devToolbar" > observes="devtoolsMenuBroadcaster_DevToolbar"/> We want to keep this menuitem: the combo button is not obvious and can be missed. >+#ifndef XP_MACOSX >+ <broadcaster id="devtoolsMenuBroadcaster_WebDeveloper" >+ /> >+#endif I would not create a new <broadcaster>, and instead of observers=…, I'd use command="Tools:DevToolbox".
Attachment #692463 - Flags: review?(paul) → review-
Attached patch patch v2.0 (deleted) — — Splinter Review
You just made the patch so easy..
Attachment #692463 - Attachment is obsolete: true
Attachment #693009 - Flags: review?(paul)
(In reply to Girish Sharma [:Optimizer] from comment #7) > You just made the patch so easy.. Yeah, I'm like that :D
Attachment #693009 - Flags: review?(paul) → review+
Whiteboard: [has-patch] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/c55a8f678488
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c55a8f678488
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: