User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20121204 Firefox/19.0 Build ID: 20121204042015 Steps to reproduce: Set Windows's DPI to something high enough that you can notice scaling on 96dpi images. Launch Firefox. Actual results: Observe that the icons in the Start Page are the low-resolution, 96dpi versions. Expected results: The high resolution icons should be used, as on Mac OSX.

Reproduced on the 12/10 Nightly, on Windows 7 64bit.

If the design folk want to provide custom graphics for 125% and/or 150% scale factors, that'd be fine; but in the meantime, we can significantly improve things by simply using the 2x graphics designed for Retina Macs when the resolution scale is 150% (144dpi) or higher. Downscaling is better than upscaling. :) (We could even do this for 125%, but at that size the downscaled 2x Sync icon looked a little rough to me, so I'm proposing to make this kick in at 150%, at least for the time being. At 125%, the upscaled standard-size graphics don't look so bad anyway...)

This shows the improvement we can get at 150% scale by using the Retina graphics; overall, they look a lot crisper.

Comment on attachment 731875 [details] [diff] [review] patch, use the 2x (Mac Retina) graphics for about:home on Windows at 150% or larger Review of attachment 731875 [details] [diff] [review]: ----------------------------------------------------------------- Could you also fix the search engine logo in aboutHome.js? (Look for instances of `imageHD`.) Since we're simply hard-coding the images, which means that both data urls will get evaluated in JS anyway, I think we should get rid of the hacky `imageHD` property and `if` branch and simply set the 2x image data url as the `image` property until we get search engine logo images moved into the OpenSearch definition files. ::: browser/base/content/abouthome/aboutHome.css @@ +348,5 @@ > +/* [HiDPI] > + * At 150% (1.5dppx) or higher, prefer downscaling the 2x Retina graphics > + * rather than upscaling the original-size ones (bug 818940). > + */ > +@media (min-resolution: 1.5dppx) { I discussed this with Stephen, and I think we'd prefer to scale the 2x graphics for anything over 100%. The media query should be: @media not all and (max-resolution: 1dppx) Media query operator precedence doesn't make sense. :/

Having this coded in a data: URL is horrible! But fixing that is left for another bug, another day...

Comment on attachment 732810 [details] [diff] [review] part 2 - also use the 2x version of the search logo (unconditionally) Review of attachment 732810 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Jonathan Kew (:jfkthame) from comment #7) > Having this coded in a data: URL is horrible! But fixing that is left for > another bug, another day... Yes, we know it's horrible. We'll fix it in bug 853992. Thanks for working on this. :) Just curious, what did you use to split up the gigantic data url into neat ~70-character chunks?

I used a regex search-and-replace in TextWrangler, roughly equivalent to s/([^ ]{70})/"\1"\n /g or words to that effect.

https://hg.mozilla.org/integration/mozilla-inbound/rev/460e5359bf20 https://hg.mozilla.org/integration/mozilla-inbound/rev/997b1d4d3122

https://hg.mozilla.org/mozilla-central/rev/460e5359bf20 https://hg.mozilla.org/mozilla-central/rev/997b1d4d3122