Closed
Bug 819038
Opened 12 years ago
Closed 12 years ago
mozcrash uses mozlog which prefixes PROCESS-CRASH lines with "mozcrash INFO |", breaking TBPL parsing
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 828324
People
(Reporter: emorley, Unassigned)
References
(Blocks 2 open bugs)
Details
eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=17553540&tree=Mozilla-Inbound
{
Finished running tests.
To run this test set MOZ_WEBRTC_TESTS=1 in your environment
make[1]: Leaving directory `/builds/slave/m-in-lnx64/build/obj-firefox/media/webrtc/signaling/test'
make -C media/mtransport/test check
make[1]: Entering directory `/builds/slave/m-in-lnx64/build/obj-firefox/media/mtransport/test'
cppunittests INFO | Running test ice_unittest
cppunittests INFO | Running test nrappkit_unittest
cppunittests INFO | Running test sockettransportservice_unittest
cppunittests INFO | Running test transport_unittests
mozcrash INFO | PROCESS-CRASH | transport_unittests | application crashed (minidump found)
mozcrash INFO | Crash dump filename: /tmp/tmpHqR5aV/50e958c8-d9ad-8212-137e1b9e-3ef789a5.dmp
mozcrash INFO | Saved dump as /builds/slave/m-in-lnx64/minidumps/50e958c8-d9ad-8212-137e1b9e-3ef789a5.dmp
cppunittests TEST-UNEXPECTED-FAIL | transport_unittests | test crashed
cppunittests INFO | Running test runnable_utils_unittest
}
"mozcrash INFO | PROCESS-CRASH | transport_unittests | application crashed (minidump found)"
is normally:
"PROCESS-CRASH | transport_unittests | application crashed ..."
etc
Comment 1•12 years ago
|
||
Yeah, it's using the mozlog module which is sticking that junk at the beginning. We can either figure out how to make mozlog not do that or we can just swap that out for print in mozcrash.
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Summary: Compiled unit tests do not use the normal log format → mozcrash uses mozlog which prefixes PROCESS-CRASH lines with "mozcrash INFO |", breaking TBPL parsing
Reporter | ||
Updated•12 years ago
|
Component: General → Mozbase
QA Contact: hskupin
Comment 2•12 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> Yeah, it's using the mozlog module which is sticking that junk at the
> beginning. We can either figure out how to make mozlog not do that or we can
> just swap that out for print in mozcrash.
Once this is running with mozharness there will also be things appended to the beginning even if print is used.
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Once this is running with mozharness there will also be things appended to
> the beginning even if print is used.
True, but I'm planning on catering for mozharness more in TBPL soon, so that shouldn't affect starring ability :-)
My main concern here is consistency. If we would like all log entries to eventually follow a format like:
{
hh:mm:ss INFO - mozcrash INFO | PROCESS-CRASH | testname | foo
}
...then that's fine (other than ideally removing a bit of INFO redundancy above) - but at the moment we don't include the module name for any other types of failures - unless I'm missing something?
Reporter | ||
Comment 4•12 years ago
|
||
Will be fixed by bug 828324
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Updated•12 years ago
|
Assignee: emorley → nobody
You need to log in
before you can comment on or make changes to this bug.
Description
•