Once Bug 815523 lands we need to backout the workaround introduced on Bug 813468

Fernando, can you take this?

Sure! I'll have to wait until Bug 815523 lands though :).

Bug 815523 is now FIXED so we should be good to back out the temporary hacks here.

Testing with the "Signed app" on http://people.mozilla.com/~fdesre/openwebapps/test.html I see $ adb shell ls -l /data/local/webapps drwxr-xr-x root root 2012-12-31 19:32 {7bbba2a3-5f90-4a32-930e-6bb862217aaf} so the package is still installed world-readable. Are there any other hacks we need to revert?

Note - for testing, here's the latest and greatest version of that app for testing (with a bunch of bug fixes): https://marketplace-dev.allizom.org/app/test-webapi-permissions There's a bunch of others you can use for testing on https://marketplace-dev.allizom.org as well.

Comment on attachment 696847 [details] [diff] [review] Revert permission hacks from bug 813468 Review of attachment 696847 [details] [diff] [review]: ----------------------------------------------------------------- I don't know what other than this we put in. Fernando and/or Fabrice are the right people to ask. But this change looks good to me.

Chris' patch is exactly what I had in mind. Afaik there are no other hacks to revert in the Gecko side. I'll take a look though.

In fact, the patch works for me with an eng build: root@android:/data/local/webapps # ls -l [...] drwxrwxr-x root root 2013-01-08 06:14 vcardimporter.gaiamobile.org drwxrwxr-x root root 2013-01-08 06:14 video.gaiamobile.org drwxrwxr-x root root 2013-01-08 06:14 wallpaper.gaiamobile.org -rw-r----- root root 30203 2013-01-08 06:23 webapps.json drwxr-x--- root root 2013-01-08 06:23 {36f128f7-d6d8-47ef-9df0-c1053316e90e} drwxr-x--- root root 2013-01-08 06:19 {3a8a1d16-fa2f-4f3c-8257-b0de109533cd} drwxr-x--- root root 2013-01-08 06:21 {e2d6ca9f-4ec0-4ec9-8975-9ed9f288d8d4} drwxr-x--- root root 2013-01-08 06:20 {eb6804cc-474d-4dff-8a8d-de411a0c4fda} I've installed the app that Chris mentioned in comment 4 and apps from https://github.com/ferjm/apptester

Please test with a "user" build.

With this patch, I get the installation done with the following permissions (in a user build): root@android:/data/local/webapps # ll -rw-r----- root root 12451 2013-01-08 19:35 webapps.json drwxr-x--- root root 2013-01-08 19:35 {756e74a7-b59f-4f6d-aba7-3c2c67cb6d7d} and -rw-r----- root root 172886 2013-01-08 19:35 application.zip -rw-r----- root root 482 2013-01-08 19:35 manifest.webapp -rw-r----- root root 431 2013-01-08 19:35 update.webapp

Backed out for Moth orange: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f5cce9b791c It's crashing in test_install_receipts.xul, e.g.: https://tbpl.mozilla.org/php/getParsedLog.php?id=18608277&tree=Mozilla-Inbound 0 XUL!(anonymous namespace)::AppUninstallObserver::Observe(nsISupports*, char const*, unsigned short const*) [nsPermissionManager.cpp : 137 + 0x0] 1 XUL!nsObserverList::NotifyObservers(nsISupports*, char const*, unsigned short const*) [nsObserverList.cpp : 99 + 0xe] 2 XUL!nsObserverService::NotifyObservers(nsISupports*, char const*, unsigned short const*) [nsObserverService.cpp : 161 + 0xd] 3 XUL!NS_InvokeByIndex_P [xptcinvoke_x86_64_unix.cpp : 162 + 0x3] 4 XUL!CallMethodHelper::Call() [XPCWrappedNative.cpp : 3085 + 0x4] 5 XUL!XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) [XPCWrappedNative.cpp : 2385 + 0x7] 6 XUL!XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) [XPCWrappedNativeJSOps.cpp : 1488 + 0x9] 7 XUL!js::CallJSNative(JSContext*, int (*)(JSContext*, unsigned int, JS::Value*), JS::CallArgs const&) [jscntxtinlines.h : 373 + 0x5] 8 XUL!js::InvokeKernel(JSContext*, JS::CallArgs, js::MaybeConstruct) [jsinterp.cpp : 391 + 0xa] 9 XUL!js::Interpret(JSContext*, js::StackFrame*, js::InterpMode) [jsinterp.cpp : 2368 + 0x2c] 10 XUL!js::RunScript(JSContext*, JS::Handle<JSScript*>, js::StackFrame*) [jsinterp.cpp : 348 + 0x9] 11 XUL!js::InvokeKernel(JSContext*, JS::CallArgs, js::MaybeConstruct) [jsinterp.cpp : 406 + 0x7] 12 XUL!js::Invoke(JSContext*, JS::Value const&, JS::Value const&, unsigned int, JS::Value*, JS::Value*) [jsinterp.h : 112 + 0x23] 13 XUL!JS_CallFunctionValue(JSContext*, JSObject*, JS::Value, unsigned int, JS::Value*, JS::Value*) [jsapi.cpp : 5806 + 0x1e] 14 XUL!nsFrameMessageManager::ReceiveMessage(nsISupports*, nsAString_internal const&, bool, mozilla::dom::StructuredCloneData const*, JSObject*, nsTArray<nsString>*, JSContext*) [nsFrameMessageManager.cpp : 621 + 0x7] 15 XUL!nsFrameMessageManager::ReceiveMessage(nsISupports*, nsAString_internal const&, bool, mozilla::dom::StructuredCloneData const*, JSObject*, nsTArray<nsString>*, JSContext*) [nsFrameMessageManager.cpp : 634 + 0x43] 16 XUL!nsAsyncMessageToSameProcessParent::Run() [nsFrameMessageManager.cpp : 1241 + 0x2b] 17 XUL!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp : 627 + 0x5]