Closed
Bug 819216
Opened 12 years ago
Closed 12 years ago
Permissions Installer - is coded to only allow |storage| to certified apps, but permissions matrix says all apps should be ALLOW_ACTION
Categories
(Firefox OS Graveyard :: General, defect, P1)
Tracking
(blocking-basecamp:-)
RESOLVED
WORKSFORME
blocking-basecamp | - |
People
(Reporter: pauljt, Unassigned)
References
Details
The permissions installer states the following:
"storage": {
212 app: DENY_ACTION,
213 privileged: DENY_ACTION,
214 certified: ALLOW_ACTION,
215 substitute: [
216 "indexedDB-unlimited",
217 "offline-app",
218 "pin-app"
219 ]
220 }
In the permission matrix, it says it should be ALLOW_ACTION for all apps (and none for web content). I'm pretty the PermissionsInstaller needs to be updated here to reflect the matrix.
Reporter | ||
Updated•12 years ago
|
blocking-basecamp: - → ?
I'm not actually sure what to do with this permission. Right now I believe we implicitly grant this permission to all apps when they are installed, whether they list "storage" in the manifest or not.
It'd be hard to require this to be added to all manifests given that we have so many floating around already.
Flags: needinfo?(jonas)
Reporter | ||
Comment 2•12 years ago
|
||
If these are internal permissions that you don't need to ask for, can we just remove storage from the matrix entirely? Is there a use case for put 'storage' in a manifest ever?
The intent was that you wouldn't get these permissions if you didn't.
Flags: needinfo?(jonas)
Comment 4•12 years ago
|
||
Jonas is going to file a separate bug to have versions in manifests. That will allow us to make compatibility-breaking changes to this sort of thing in the future.
blocking-basecamp: ? → -
Comment 5•12 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/PermissionsTable.jsm#204
looks like this has been fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
Works for me actually - this was fixed in a different patch by Fabrice. Thanks for closing this though.
Resolution: FIXED → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•