Closed
Bug 819228
Opened 12 years ago
Closed 12 years ago
Gaia's build/utils.js writeContent should preserve unicode encoding
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
(Whiteboard: QARegressExclude)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
using writeContent to write unicode into a file results in broken file
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Comment 2•12 years ago
|
||
I don't see any issues with our manifest files being in UTF8. I see errors when I encode any manifest in something else than UTF8, as platform code try to read them in this charset. But it still fails with your patch. So which concrete issues are your addressing here with this patch?
Assignee | ||
Comment 3•12 years ago
|
||
When reading and writing back HTML files that contain UTF8 chars I'm loosing all charcodes if I don't use the patch.
Comment 4•12 years ago
|
||
I’m using a `writeContent_UTF8' variant in the patch I proposed for bug 821691. If the latter lands, I guess we can close this bug. We could also make bug 821691 depend on this one.
Comment 5•12 years ago
|
||
fixed along with bug 821691: https://github.com/mozilla-b2g/gaia/commit/5fe546fda8a44a33e8feea782530b1827dd4ca1c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment #689561 -
Flags: review?
You need to log in
before you can comment on or make changes to this bug.
Description
•