Closed Bug 819419 Opened 12 years ago Closed 11 years ago

Intermittent testAllPagesTab | Awesomebar URL stayed the same - got https://addons.mozilla.org/en-US/android/, expected http://mochi.test:8888/tests/robocop/robocop_big_link.html (and several more)

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME
Milestone:
Firefox 22

People

(Reporter: emorley, Assigned: gbrown)

References

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

speculative fix + more diagnostics
(deleted), patch
jmaher
: review+
Details | Diff | Splinter Review
screenshot from Comment 99
(deleted), image/jpeg
Details
screenshot from Comment 102 (different case)
(deleted), image/jpeg
Details
Android Tegra 250 mozilla-inbound opt test robocop on 2012-12-05 13:12:56 PST for push e1cdd4d430ca slave: tegra-232 https://tbpl.mozilla.org/php/getParsedLog.php?id=17643177&tree=Mozilla-Inbound { 20 INFO TEST-PASS | testAllPagesTab | TextView is filled in - http://mochi.test:8888/tests/robocop/robocop_big_link.html 21 INFO TEST-PASS | testAllPagesTab | Correct number of ImageViews visible - 1 should equal 1 22 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | Awesomebar URL stayed the same - got https://addons.mozilla.org/en-US/android/, expected http://mochi.test:8888/tests/robocop/robocop_big_link.html Exception caught during test! junit.framework.AssertionFailedError: 22 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | Awesomebar URL stayed the same - got https://addons.mozilla.org/en-US/android/, expected http://mochi.test:8888/tests/robocop/robocop_big_link.html at junit.framework.Assert.fail(Assert.java:47) at org.mozilla.fennec.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:107) at org.mozilla.fennec.FennecMochitestAssert.ok(FennecMochitestAssert.java:136) at org.mozilla.fennec.FennecMochitestAssert.is(FennecMochitestAssert.java:142) at org.mozilla.fennec.tests.BaseTest.verifyUrl(BaseTest.java:226) at org.mozilla.fennec.tests.testAllPagesTab.testClick(testAllPagesTab.java:142) at org.mozilla.fennec.tests.testAllPagesTab.testAllPagesTab(testAllPagesTab.java:56) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:521) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186) at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:120) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447) 23 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | Exception caught - junit.framework.AssertionFailedError: 22 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | Awesomebar URL stayed the same - got https://addons.mozilla.org/en-US/android/, expected http://mochi.test:8888/tests/robocop/robocop_big_link.html }
I can't tell quickly from the test code, but are we attempting to load addons.mozilla.org ? We should avoid trying to load the two live websites here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testAllPagesTab.java.in#38
Flags: needinfo?(wjohnston)
try run at https://tbpl.mozilla.org/?tree=Try&rev=3f7302bb4914 provides a logcat with some (fairly ineffective) additional logging. https://tbpl.mozilla.org/php/getParsedLog.php?id=18578263&tree=Try&full=1#error7 contains: 01-07 21:11:53.847 E/GeckoConsole( 9581): [JavaScript Warning: "Error in parsing value for 'background-image'. Declaration dropped." {file: "https://addons.mozilla.org/en-US/android/" line: 5}] 01-07 21:11:53.847 E/GeckoConsole( 9581): [JavaScript Warning: "Error in parsing value for 'background-image'. Declaration dropped." {file: "https://addons.mozilla.org/en-US/android/" line: 5}] 01-07 21:11:53.847 E/GeckoConsole( 9581): [JavaScript Warning: "Error in parsing value for 'display'. Declaration dropped." {file: "https://addons.mozilla.org/en-US/android/" line: 5}] ...etc This happens after the robocop click -- has the click gone astray and requested a load of the addons page?
try run at https://tbpl.mozilla.org/?tree=Try&rev=ef918c3dab48 confirms the results of Comment 15 and also verifies that the clicked view is the "Big Link" item -- not the addons item. I suspect there is something in the all pages tab that is misinterpreting the click, or loading the wrong page.
(In reply to Mark Finkle (:mfinkle) from comment #11) > I can't tell quickly from the test code, but are we attempting to load > addons.mozilla.org ? We should avoid trying to load the two live websites > here: > http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/ > testAllPagesTab.java.in#38 The test is sometimes loading addons.mozilla.org, but it is not intentional -- we are clicking on a mochi.test:8888 link and it is being misinterpreted, somehow. The test code looks sound.
Flags: needinfo?(wjohnston)
I am not 100% sure of what is causing this intermittent failure. Speculative fix: Since testClick's getAllPagesList() call does not specify an expected number of children, we may be getting a ListView that has not yet been fully populated; change this to specify the expected number of children. More diagnostics: In case this keeps failing, this patch adds a dumpLog to display the text contents of the ListView item just before clicking on it.
Assignee: nobody → gbrown
Attachment #725438 - Flags: review?(jmaher)
Comment on attachment 725438 [details] [diff] [review] speculative fix + more diagnostics Review of attachment 725438 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tests/testAllPagesTab.java.in @@ +145,5 @@ > + TextView t = (TextView)v; > + String string = t.getText().toString(); > + mAsserter.dumpLog("first list item has text: " + string); > + } > + } can we add a comment here to indicate we are debugging.
Attachment #725438 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/6b990517cb94
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
At least the new diagnostics are working: 03-18 10:21:47.534 I/Robocop ( 1749): first list item has text: Big Link 03-18 10:21:47.534 I/Robocop ( 1749): first list item has text: http://mochi.test:8888/tests/robocop/robocop_big_link.html ...so we click on "Big Link" and load the addons page -- why would that be?
could we be loading addons in another tab and maybe we are on that tab?
Attached image screenshot from Comment 99 (deleted) —
this is a tegra only failure, so we need to debug this on tegras.
For my follow-up: There is a promising but not quite successful diagnostic patch at https://tbpl.mozilla.org/?tree=Try&rev=0b81e40705f8.
I have not been able to repro this for some weeks now.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 11 years ago
Resolution: --- → WORKSFORME
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=879505
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: