(inactive after 6/18) Alive Kuo [:alive] Reporter
	Description • 12 years ago

This is follow up of bug 811222 and bug 815445.

The audio-channel-changed event is expected to be got with 'telephony' when on a call.

This blocks bug 810780 but I had a workaround in gaia. Anyway this should be fixed.

	Walter Chen[:ypwalter][:wachen]
	Comment 1 • 12 years ago

This should be P1 bb+ due to blocking of a P1 bb+ bug (C2).
Anyone who can take this, please take this asap.

	Marco Chen [:mchen] Assignee
	Comment 2 • 12 years ago

1. The root cause of original code is that audio-change-event is triggered by AudioChannelService::UnregisterType(). But new API for telephony just changed the ref count of telephony channel but not do Register/UnregisterType(). So no event will be fired.

2. This patch tried to use AudioChannelAgent to instead of new APIs so this way will trigger the Register/UnregsiterType() then event will be fired.

	Andrea Marchesini [:baku]
	Comment 3 • 12 years ago

Comment on attachment 690344 [details] [diff] [review]
v1

Review of attachment 690344 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/AudioManager.cpp
@@ +304,5 @@
>  
>    mPhoneState = aState;
> +
> +  if (aState == PHONE_STATE_IN_CALL) {
> +    mPhoneAudioAgent = do_CreateInstance("@mozilla.org/audiochannelagent;1");

What about:

if (aState == PHONE_STATE_IN_CALL) {
  if (!mPhoneAudioAgent) {
    mPhoneAudioAgent = do_CreateInstance("@mozilla.org/audiochannelagent;1");
    MOZ_ASSERT(mPhoneAudioAgent);
    // Telephony doesn't be paused by any other channels.
    mPhoneAudioAgent->Init(AUDIO_CHANNEL_TELEPHONY, nullptr);
  }

  // Telephony can always play.
  bool canPlay;
  mPhoneAudioAgent->StartPlaying(&canPlay);
} else if (mPhoneAudioAgent) {
  ...
}

	Marco Chen [:mchen] Assignee
	Comment 4 • 12 years ago

Add reviewer and blocking-basecamp

	Marco Chen [:mchen] Assignee
	Comment 5 • 12 years ago

Following comment.

	Marco Chen [:mchen] Assignee
	Comment 6 • 12 years ago

Removing blanking.

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a2c761e196c

	Ed Morley [:emorley]
	Comment 8 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/7a2c761e196c

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 12 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/3bdca8193789
https://hg.mozilla.org/releases/mozilla-b2g18/rev/c645fa53e941