This will require using string bundles, which are currently not used in Toolbox.jsm . Should I use browser.properties file, or any other file ? Also, what tooltip text is expected on the tabs ?

Create toolbox.properties. For the tabs, I guess you need to add a new property to the tool definitions (.tooltip). Debugger: "JavaScript Debugger" StyleEditor: "CSS Stylesheets Editor" Inspector: "DOM and Style Inspector" WebConsole: "Web Console"

Add tooltips to tabs, close button and dock buttons.

Comment on attachment 693060 [details] [diff] [review] Add tooltips r+ with this addressed: Can you please validate that with a native english speaker? +toolboxDockButtons.bottom.tooltip=Dock to bottom of the tab +toolboxDockButtons.side.tooltip=Dock to the sidebar +toolboxDockButtons.window.tooltip=Undock to a seperate window I would not say "Dock to bottom of the tab" but "Dock into the browser" (not mentioning tab). (also, I think we have the profile now)

(In reply to Paul Rouget [:paul] from comment #4) > I would not say "Dock to bottom of the tab" but "Dock into the browser" (not > mentioning tab). When the toolbox is in the sidebar, then Dock into the browser would not make sense. > (also, I think we have the profile now) Yeah, I would update my patch with that.

Comment on attachment 693060 [details] [diff] [review] Add tooltips Review of attachment 693060 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/locales/en-US/chrome/browser/devtools/toolbox.properties @@ +1,3 @@ > +toolboxDockButtons.bottom.tooltip=Dock to bottom of the tab > +toolboxDockButtons.side.tooltip=Dock to the sidebar > +toolboxDockButtons.window.tooltip=Undock to a seperate window \ No newline at end of file Could I suggest: toolboxDockButtons.bottom.tooltip=Dock to bottom of browser window toolboxDockButtons.side.tooltip=Dock to side of browser window toolboxDockButtons.window.tooltip=Show in separate window (Note the spelling of sep_a_rate)

(In reply to Joe Walker [:joe_walker] [:jwalker] from comment #6) > toolboxDockButtons.bottom.tooltip=Dock to bottom of browser window > toolboxDockButtons.side.tooltip=Dock to side of browser window > toolboxDockButtons.window.tooltip=Show in separate window Yes, these sound more accurate. > (Note the spelling of sep_a_rate) :P typo. Also, what should I use for Profiler tab ? Panos suggested to go with just "Profiler" . If that is okay, I will submit the patch including that.

Profiler sounds good to me. It's not impossible that we will have a CSS Profiler one day, but we can think about new names then.

Carry forward Joe's r+ Fixed the string he mentioned, the new line and added Profiler.

Looks like the jar.mn changes did not get pushed. So the docking buttons have "undefined" tooltip

Closing as it will be handled in bug 823998 now