Closed
Bug 820100
Opened 12 years ago
Closed 12 years ago
[e.me] browser context shouldn't be shared between two apps
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Firefox OS Graveyard
Gaia::Everything.me
Tracking
(b2g18+ fixed, b2g18-v1.0.1 fixed)
RESOLVED
FIXED
People
(Reporter: ochameau, Assigned: crdlc)
References
Details
Attachments
(1 file)
(deleted),
text/html
|
alive
:
review+
lsblakk
:
approval-gaia-v1+
|
Details |
Bug 807438 introduced some regressions.
Test case:
1) go to Facebook
2) close facebook
3) go to twitter
4) open footer
Current result:
See back button enabled, click back -> go to Facebook (but the back should be disabled)
Expected result:
Back button disabled
One other unexpected result is that when you open twitter, you may see facebook appear while twitter is loading.
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 1•12 years ago
|
||
Hi Alexandre, do you have any update? thanks
Flags: needinfo?(poirot.alex)
Reporter | ||
Comment 2•12 years ago
|
||
Sorry, I went back to my original team.
So I don't think that I'll have time to fix that anytime soon.
Assignee: poirot.alex → nobody
Flags: needinfo?(poirot.alex)
Assignee | ||
Comment 3•12 years ago
|
||
I will take a look to this, thanks
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #710098 -
Flags: review?(alive)
Comment 5•12 years ago
|
||
(In reply to crdlc from comment #4)
> Created attachment 710098 [details]
> Patch v1
I don't see why the fix works. See github comments. Could you please give some explanation?
Assignee | ||
Comment 6•12 years ago
|
||
here the explanation:
https://github.com/mozilla-b2g/gaia/pull/7956/files#r2890774
Comment 7•12 years ago
|
||
Comment on attachment 710098 [details]
Patch v1
I could r+ the fix but please provide a unit test.
This issue is not emergent, so I guess we have some time to learn writing a test.
Please give a unit test about wrapper if possible.
Window Manager itself now is not unit testable...I am working on this.
Attachment #710098 -
Flags: review?(alive)
Assignee | ||
Comment 8•12 years ago
|
||
ok working on it
Assignee | ||
Updated•12 years ago
|
Attachment #710098 -
Flags: review?(alive)
Comment 9•12 years ago
|
||
Comment on attachment 710098 [details]
Patch v1
r=me if next time you have unit test as we discussed offline.
Attachment #710098 -
Flags: review?(alive) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 710098 [details]
Patch v1
IMHO sharing history of navigation among apps and what users can view the last webapp while the current is loading is ugly. I mean, this is not a blocker but the experience is not good. Nominating... so you can decide if it could go in v1. Thanks
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: bad user experience
Testing completed: in my device
Risk to taking this patch (and alternatives if risky): low
Attachment #710098 -
Flags: approval-gaia-v1?
Assignee | ||
Comment 11•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 12•12 years ago
|
||
As Cristian, says, sharing navigation history across apps is quite weird, based on the risk/reward I think we should take this one to v1-train.
Assignee | ||
Comment 13•12 years ago
|
||
Everything.me guys have tested it on master and they said to me that it is working fine
Updated•12 years ago
|
status-b2g18:
--- → affected
tracking-b2g18:
--- → +
Comment 14•12 years ago
|
||
Comment on attachment 710098 [details]
Patch v1
Approving this tested fix for v1-train uplift.
Attachment #710098 -
Flags: approval-gaia-v1? → approval-gaia-v1+
Comment 15•12 years ago
|
||
v1-train: e2d1b046ecbf3f79a18e8bae44b51fe61f111421
Updated•12 years ago
|
Comment 16•12 years ago
|
||
Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.
status-b2g18-v1.0.1:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•