Closed
Bug 820198
Opened 12 years ago
Closed 12 years ago
Refactor webpay to use solitude transactions
Categories
(Marketplace Graveyard :: Payments/Refunds, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-01-03
People
(Reporter: kumar, Assigned: andy+bugzilla)
References
Details
(Whiteboard: u=dev c=pmt p=1)
Webpay has its own transaction table. I think we can replace it with Solitude transactions via API calls. This is related to refactoring in bug 817886. See bug 795140 to get a sense for how webpay needs to work with transactions.
Reporter | ||
Updated•12 years ago
|
Priority: -- → P2
Reporter | ||
Updated•12 years ago
|
Target Milestone: --- → 2012-12-20
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → amckay
Assignee | ||
Comment 1•12 years ago
|
||
After chatting in irc with kumar, here's what I think we should do.
When the initial JWT comes in we:
* in webpay stuff the JWT and a transaction id into the session
* create a transaction in solitude that's in the pending state, it will have no amount yet. This gives us auditability of that transaction.
When any changes occur we then update that transaction in solitude as we need to. Webpay will be able to access the JWT and any data in there until the transaction is completed.
Assignee | ||
Comment 2•12 years ago
|
||
Solitude changes: https://github.com/mozilla/solitude/commit/a58bed
Updated•12 years ago
|
Target Milestone: 2012-12-20 → 2013-01-03
Updated•12 years ago
|
Whiteboard: u=dev c=pmt p=2
Updated•12 years ago
|
Whiteboard: u=dev c=pmt p=2 → u=dev c=pmt p=1
Reporter | ||
Comment 3•12 years ago
|
||
I had to add some stub code to work around the solitude transaction model. These changes should be undone when the refactoring lands:
https://github.com/mozilla/webpay/commit/e00de15fe8b85b2aab72bbf5bcb82b1d08aea198
https://github.com/mozilla/solitude/commit/8407aa6a5d1aa2710a9bd4bd39d9416f99b2933e
Assignee | ||
Comment 4•12 years ago
|
||
https://github.com/mozilla/webpay/commit/278656 and reverted those commits. Lets see what breaks.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•