Paul Rouget [:paul] Reporter
	Description • 12 years ago

1. Open debugger
2. Undock the window
3. Close the window
4. Open the debugger (the window should already be undocked by now)
5. Dock the window
6. Try to add a conditional breakpoint or focus the "Filter Scripts" textbox
-> No panels will ever be visible or accessible

Exception:

> Error: An error occurred updating the cmd_undo command: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULCommandDispatcher.getControllerForCommand]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 71"  data: no]
> Source File: chrome://global/content/globalOverlay.js
> Line: 81

	Girish Sharma [:Optimizer]
	Comment 1 • 12 years ago

This happens for normal panels too (search keyword suggestion arrow panel)

	Victor Porof [:vporof][:vp] Assignee
	Comment 2 • 12 years ago

The side panels have no relation whatsoever to a xul <panel>. Please don't change the bug description if you're not sure.

	Girish Sharma [:Optimizer]
	Comment 3 • 12 years ago

Okay my bad, but if I follow the STR's, the side panels *do* show up for me perfectly fine (although the exceptions from comment 0 do come). But then again, those exceptions come as soon as I hit right click on any line.

The issue here is that if you do not move your mouse after clicking on add conditional breakpoint, you will *not see* the panels. When you move your mouse, you will see them.

The same goes for the arrow panel. follow the STR, and instead click on the Search Box, you will not *see* the arrow panel, but it is there. This can be proved by the fact that you do not see a resize cursor at the place where the arrow panel was supposed to be *painted*, but your mouse will change into resize cursor anywhere else to the right/left of that area.

Also, you will require 2 clicks to do anything like closing the toolbox, clicking on any link etc.

Thus the issue is exactly same. For some reason, the layers are not getting repainted when the window is docked, but for only those payers that did not get painted even once while the window was undocked. This seems to be a dlbi regression, not anything to do with panel or sidepanel.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 4 • 12 years ago

I'll look into this.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 5 • 12 years ago

(In reply to Paul Rouget [:paul] from comment #0)
> > Error: An error occurred updating the cmd_undo command: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULCommandDispatcher.getControllerForCommand]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 71"  data: no]
> > Source File: chrome://global/content/globalOverlay.js
> > Line: 81

This error message seems related to bug 817551. I'd like to fix this first and see if it is the cause of the missing panels, but I need to understand the toolbox detach and reattach process first.

	Paul Rouget [:paul] Reporter
	Comment 6 • 12 years ago

There's a patch for bug 817551. It doesn't appear to fix this.

	Victor Porof [:vporof][:vp] Assignee
	Comment 7 • 12 years ago

Adding 
> aFlags.animated = false;
on the first line of DV__togglePanes in debugger-view.js (to always disable transitions when toggling the panes) fixes the problem.

Apparently this has something to do with the fact that transitions don't work property after a swapFrameLoaders. However, I'm confused as why this only breaks when switching from window to docked.

	Victor Porof [:vporof][:vp] Assignee
	Comment 8 • 12 years ago

s/property/properly/

	Paul Rouget [:paul] Reporter
	Comment 9 • 12 years ago

Can we get a workaround implementation asap (we want that in Firefox 20)?
What would be the right approach here? Force aFlags.animated to false right on "host-changed"?

	Victor Porof [:vporof][:vp] Assignee
	Comment 10 • 12 years ago

(In reply to Paul Rouget [:paul] from comment #9)
> Can we get a workaround implementation asap (we want that in Firefox 20)?
> What would be the right approach here? Force aFlags.animated to false right
> on "host-changed"?

That would be acceptable. Taking.

	Victor Porof [:vporof][:vp] Assignee
	Comment 11 • 12 years ago

(In reply to Victor Porof [:vp] from comment #10)
> (In reply to Paul Rouget [:paul] from comment #9)
> > Can we get a workaround implementation asap (we want that in Firefox 20)?
> > What would be the right approach here? Force aFlags.animated to false right
> > on "host-changed"?
> 
> That would be acceptable. Taking.

"<paul> before jumping on the workaround for the panel, let's see what the platform people will say about the transition problem."

	Victor Porof [:vporof][:vp] Assignee
	Comment 12 • 12 years ago

Fixed by bug 832920 (yay!).