Closed Bug 820507 Opened 12 years ago Closed 9 years ago

validation on balrog permissions' options doesn't happen

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: ashish.sareen95)

References

Details

(Whiteboard: [balrog])

Peter found this today - it silently accepts and throws away bad JSON.
1. You're allowed to enter new permissions with the "Options" field blank. 2. Trying to do an update with invalid input to the "Options" field does not complain with an error.
Priority: -- → P3
Product: mozilla.org → Release Engineering
This is probably something on the backend...
Component: General Automation → Balrog: Backend
QA Contact: catlee → bhearsum
I can have a look at it. Could you please assign this bug to me ?
Assignee: nobody → ashish.sareen95
Ashish looked into this and couldn't find any cases where it happened anymore. I dug through blame and it looks like it was fixed by https://github.com/mozilla/balrog/commit/e1940615ffda8b539d7e4ea787dae82ec2027498.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.