Closed Bug 820711 Opened 12 years ago Closed 12 years ago

[FTE] No counter of PIN attempts

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
All
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Milestone:
B2G C3 (12dec-1jan)
Project Flags:
blocking-basecamp +

People

(Reporter: askeing, Assigned: mbudzynski)

References

Details

(Keywords: late-l10n)

Attachments

(1 file)

patch
(deleted), text/html
fcampo
: review+
stas
: review+
Details
Tested with unagi_2012-12-11_eng.zip. In the FTU app, the PIN lock interface does not have counter of PIN attempts. It should be important. Thanks. ref: Bug 818172
It should be a P1 blocking issue as well.
blocking-basecamp: --- → ?
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → All
Summary: [FTU] No counter of PIN attempts → [FTE] No counter of PIN attempts
Is showing PIN attempts within v1 feature scope?
Flags: needinfo?(clee)
adding Peter to see if he can also provide a response
Flags: needinfo?(pdolanjski)
Flags: needinfo?(dcoloma)
This was considered a blocker for the "regular" switch-on (without FTE) in bug 820711 so I think this should be a blocker as the problem is the same.
Flags: needinfo?(dcoloma)
Agree, we should be consistent here with the normal PIN lock. Let's mark bb+.
Flags: needinfo?(clee)
blocking-basecamp: ? → +
Priority: -- → P1
Flags: needinfo?(pdolanjski)
Assignee: nobody → fbsc
Target Milestone: --- → B2G C3 (12dec-1jan)
Assignee: fbsc → fernando.campo
Assignee: fernando.campo → mbudzynski
Attached file patch (deleted) —
Attachment #693579 - Flags: review?(fernando.campo)
Comment on attachment 693579 [details] patch Sorry, can't approve until regression issues are solved (comments in github). Please rebase and fix them, and update the pull request :)
Attachment #693579 - Flags: review?(fernando.campo) → review-
Attachment #693579 - Flags: review- → review?(fernando.campo)
Patch fixed - changes before were based on commit from 15/12, my fault.
Keywords: late-l10n
Attachment #693579 - Flags: review?(stas)
[:fcampo] conflict resolved.
Comment on attachment 693579 [details] patch Is the current wording "The PIN was incorrect." correct? I'm not a native speaker, so it's hard for me to judge. In any case, this looks good l10n-wise. r=me.
Attachment #693579 - Flags: review?(stas) → review+
Blocks: 823581
Attachment #693579 - Flags: review?(fernando.campo) → review+
Before merging there is a little typo in the code. a = that should be - to fix before landing ;)
fixed
Merging https://github.com/mozilla-b2g/gaia/commit/54d7c73ca99dff3fd2efae1552152d4f1434342b Sorry for not waiting for you to do it michalbe, but need it merged asap to avoid conflicts on the next PR
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
device: unagi build: unagi_2012-12-24 from https://releases.mozilla.com/b2g/ Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: