Marco Bonardo [:mak] Reporter
	Description • 12 years ago

The following tests are still using addVisit:

toolkit/components/places/tests/browser/browser_bug248970.js
toolkit/components/downloads/test/unit/test_history_expiration.js
toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
toolkit/components/places/tests/cpp/places_test_harness.h

	Raymond Lee [:raymondlee] Assignee
	Comment 1 • 12 years ago

I am not very familiar code so I have just updated the js files.

	Raymond Lee [:raymondlee] Assignee
	Comment 2 • 12 years ago

(In reply to Raymond Lee [:raymondlee] from comment #1)
> Created attachment 703215 [details] [diff] [review]
> v1
> 
> I am not very familiar code so I have just updated the js files.
I mean cpp

	Marco Bonardo [:mak] Reporter
	Comment 3 • 12 years ago

Comment on attachment 703215 [details] [diff] [review]
v1

Review of attachment 703215 [details] [diff] [review]:
-----------------------------------------------------------------

please file a separate bug blocking bug 700250 to fix the cpp test.

::: toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
@@ +611,5 @@
>        os.removeObserver(observer, "cacheservice:empty-cache");
>        do_test_finished();
> +
> +      // Shutdown the download manager.
> +      Services.obs.notifyObservers(null, "quit-application", null);

please do this before invoking do_test_finished, just for coherence.

	Raymond Lee [:raymondlee] Assignee
	Comment 4 • 12 years ago

(In reply to Marco Bonardo [:mak] from comment #3)
> Comment on attachment 703215 [details] [diff] [review]
> v1
> 
> Review of attachment 703215 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> please file a separate bug blocking bug 700250 to fix the cpp test.

filed bug 832133

> 
> ::: toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
> @@ +611,5 @@
> >        os.removeObserver(observer, "cacheservice:empty-cache");
> >        do_test_finished();
> > +
> > +      // Shutdown the download manager.
> > +      Services.obs.notifyObservers(null, "quit-application", null);
> 
> please do this before invoking do_test_finished, just for coherence.

fixed

	Raymond Lee [:raymondlee] Assignee
	Comment 5 • 12 years ago

It looks good on try
https://tbpl.mozilla.org/?tree=Try&rev=bae122fbc758

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/87fe8d808537

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/87fe8d808537