Closed
Bug 821101
Opened 12 years ago
Closed 12 years ago
Contacts: Fix phonenumberJS error
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: gwagner, Assigned: gwagner)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bent.mozilla
:
review+
sicking
:
approval-mozilla-aurora+
sicking
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #691582 -
Flags: review?(bent.mozilla)
Comment on attachment 691582 [details] [diff] [review]
patch
Review of attachment 691582 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/contacts/fallback/ContactDB.jsm
@@ +270,5 @@
> debug("InternationalFormat: " + parsedNumber.internationalFormat);
> debug("InternationalNumber: " + parsedNumber.internationalNumber);
> debug("NationalNumber: " + parsedNumber.nationalNumber);
> debug("NationalFormat: " + parsedNumber.nationalFormat);
> + if (parsedNumber.internationalNumber && number.toString() !== parsedNumber.internationalNumber) {
Nit: I'd split this to two lines ;)
Attachment #691582 -
Flags: review?(bent.mozilla) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
blocking-basecamp: --- → ?
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment on attachment 691582 [details] [diff] [review]
patch
[Triage Comment]
Attachment #691582 -
Flags: approval-mozilla-b2g18+
Attachment #691582 -
Flags: approval-mozilla-aurora+
Not blocking on this since no motivation was given why this bug is important. Feel free to renom with a motivation, or just uplift the patch since I just a+'ed it.
blocking-basecamp: ? → -
|
|
Assignee | |
Comment 7•12 years ago
|
||
It can cause an Error in our ContactsDB code during importing or saving contacts and we never return from the request.
So it's impossible to save a contact or import contacts from the SIM card.
Already seen in bug 820843.
E/GeckoConsole( 674): [JavaScript Error: "(intermediate value).internationalNumber is null" {file: "resource://gre/modules/ContactDB.jsm" line: 275}]
blocking-basecamp: - → ?
blocking-basecamp: ? → +
|
||
Comment 8•12 years ago
|
||
Blocks: b2g-phonenumberjs
You need to log in
before you can comment on or make changes to this bug.
Description
•