Closed
Bug 821127
Opened 12 years ago
Closed 12 years ago
Gaia Clock: reduce ringtone sizes
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 807431
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file)
(deleted),
text/html
|
Details |
The ringtones are currently Vorbis audio, mono, 48000 Hz, ~239920 bps. 48 kHz and ~240 kbps is way overrated for the kind of speaker these will be played through.
Assignee | ||
Comment 1•12 years ago
|
||
I re-encoded the ringtones with the standard oggenc quality 3 which yields bitrates of about 80kbps. I can't hear the difference between that and the higher bitrate version on my computer with headphones!
Also dropped sampling rate to 44.1 kHz. Not sure we want to go much lower than that without compromising quality too much. rillian, what do you think?
Pull request is here: https://github.com/mozilla-b2g/gaia/pull/6987
Comment 2•12 years ago
|
||
I agree oggenc -q 3 (~80 kbps) is entirely appropriate for the ring tones. I wouldn't convert them to 44.1 though. It doesn't save much space, and most audio hardware is natively 48 kHz now (occasionally with poor-quality hardware resampling).
However, it looks like you duplicated my work from bug 807431, which is unfortunate. Did the new encodings there not land?
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Ralph Giles (:rillian) from comment #2)
> I agree oggenc -q 3 (~80 kbps) is entirely appropriate for the ring tones. I
> wouldn't convert them to 44.1 though. It doesn't save much space, and most
> audio hardware is natively 48 kHz now (occasionally with poor-quality
> hardware resampling).
Ok, good to know. I'll leave it at 48 kHz.
> However, it looks like you duplicated my work from bug 807431, which is
> unfortunate. Did the new encodings there not land?
These are the clock's alarm ringtones, not the phone's ringtones. So I don't think we duplicated any work!
Assignee | ||
Comment 4•12 years ago
|
||
Assignee: nobody → philipp
Attachment #691903 -
Flags: review?(timdream+bugs)
Comment 5•12 years ago
|
||
Phillipp,
Why are we resampling these again? We should be using Ralph's OPUS, they are 814k total.
Also clock app is redesigned already in UX branch. Please consult UX before changing visual designs, so we're not duplicating work, we have more efficient patches waiting to be merged into master.
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Patryk Adamczyk [:patryk] UX from comment #5)
> Why are we resampling these again? We should be using Ralph's OPUS, they are
> 814k total.
Ah great! Where are they?
> Also clock app is redesigned already in UX branch. Please consult UX before
> changing visual designs, so we're not duplicating work, we have more
> efficient patches waiting to be merged into master.
Sorry, I'm not aware of this UX branch. Can you point me to the bugs that are tracking this work please?
Comment 7•12 years ago
|
||
Comment on attachment 691903 [details]
pull request
Remove review? flag based on comment 5.
Attachment #691903 -
Flags: review?(timdream+bugs)
Comment 8•12 years ago
|
||
(In reply to Philipp von Weitershausen [:philikon] from comment #6)
> (In reply to Patryk Adamczyk [:patryk] UX from comment #5)
> > Why are we resampling these again? We should be using Ralph's OPUS, they are
> > 814k total.
>
> Ah great! Where are they?
>
> > Also clock app is redesigned already in UX branch. Please consult UX before
> > changing visual designs, so we're not duplicating work, we have more
> > efficient patches waiting to be merged into master.
>
> Sorry, I'm not aware of this UX branch. Can you point me to the bugs that
> are tracking this work please?
The new files are already in master under:
shared/resources/media/alarms
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Patryk Adamczyk [:patryk] UX from comment #8)
> (In reply to Philipp von Weitershausen [:philikon] from comment #6)
> > (In reply to Patryk Adamczyk [:patryk] UX from comment #5)
> > > Why are we resampling these again? We should be using Ralph's OPUS, they are
> > > 814k total.
> >
> > Ah great! Where are they?
> >
> > > Also clock app is redesigned already in UX branch. Please consult UX before
> > > changing visual designs, so we're not duplicating work, we have more
> > > efficient patches waiting to be merged into master.
> >
> > Sorry, I'm not aware of this UX branch. Can you point me to the bugs that
> > are tracking this work please?
>
> The new files are already in master under:
> shared/resources/media/alarms
Ok, cool. But which bug do we dupe this bug to then?
Updated•12 years ago
|
QA Contact: jshih → fyen
Comment 10•12 years ago
|
||
Based on comment 8.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•