Closed
Bug 821343
Opened 12 years ago
Closed 12 years ago
toolkit/mozapps/update/test/unit/xpcshell_updater.ini tests all fail in B2G (TestAUSHelper not compiled)
Categories
(Testing :: XPCShell Harness, defect)
Tracking
(firefox19 fixed, firefox20 fixed, b2g18 fixed)
RESOLVED
FIXED
mozilla20
People
(Reporter: ahal, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
Not sure if this is a harness problem or legitimate test failures, I haven't had a chance to investigate yet. If it turns out to be the latter feel free to move this bug to the proper component.
https://tbpl.mozilla.org/php/getParsedLog.php?id=17794511&tree=Cedar
Reporter | ||
Updated•12 years ago
|
Version: 18 Branch → unspecified
Assignee | ||
Comment 1•12 years ago
|
||
TestAUSHelper doesn't exist and is used by these tests
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/unit/head_update.js.in#1047
Assignee | ||
Comment 2•12 years ago
|
||
I pushed to try but the xpcshell tests for b2g are extremely backed up :(
https://tbpl.mozilla.org/?tree=Try&rev=920d425ac8ef&noignore=1
Any suggestions? Perhaps someone could check if the reenabled tests in the push to try pass and if not provide logs?
Assignee | ||
Comment 3•12 years ago
|
||
Nevermind... their time finally came up :)
Assignee | ||
Comment 4•12 years ago
|
||
Looks like this fixes most of these tests for b2g... I'll put together a patch tomorrow
Assignee: nobody → robert.bugzilla
Assignee | ||
Comment 5•12 years ago
|
||
Andrew, this is a test only fix that fixes test_0110_general.js, test_0111_general.js, test_0112_general.js, test_0114_general.js, and test_0115_general.js. I'll file a new bug for the remainder. If you approve it, where would you like it to land?
Attachment #692354 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 6•12 years ago
|
||
btw: here is the try build
https://tbpl.mozilla.org/?tree=Try&rev=920d425ac8ef&noignore=1
Reporter | ||
Comment 7•12 years ago
|
||
Comment on attachment 692354 [details] [diff] [review]
patch rev1 - compile TestAUSHelper
Review of attachment 692354 [details] [diff] [review]:
-----------------------------------------------------------------
Lgtm, thanks! Do you think the three remaining failing tests are harness related? Want me to file a bug for them?
I'll take care of landing this on the branches we need.
Attachment #692354 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #7)
> Comment on attachment 692354 [details] [diff] [review]
> patch rev1 - compile TestAUSHelper
>
> Review of attachment 692354 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Lgtm, thanks! Do you think the three remaining failing tests are harness
> related? Want me to file a bug for them?
I think they are due to differences between b2g and other platforms. I'll file the bugs and look into them.
>
> I'll take care of landing this on the branches we need.
Thanks!
Reporter | ||
Comment 9•12 years ago
|
||
Pushed to cedar first:
https://hg.mozilla.org/projects/cedar/rev/d899d5be9a10
Whiteboard: [automation-needed-in-aurora][automation-needed-in-b2g18]
Assignee | ||
Comment 10•12 years ago
|
||
Yay... the re-enabled tests also passed on cedar.
https://tbpl.mozilla.org/php/getParsedLog.php?id=17956446&tree=Cedar&full=1
Assignee | ||
Comment 11•12 years ago
|
||
Notes:
The patch in this bug is needed by most if not all updater tests.
The patch in this bug fixes test_0110_general.js, test_0111_general.js, test_0112_general.js, test_0114_general.js, and test_0115_general.js.
test_0200_app_launch_apply_update.js and test_0201_app_launch_apply_update.js will be handled in bug 821866.
test_0113_general.js I am still investigating.
Summary: toolkit/mozapps/update/test/unit/xpcshell_updater.ini tests all fail in B2G → toolkit/mozapps/update/test/unit/xpcshell_updater.ini tests all fail in B2G (TestAUSHelper not compiled)
Assignee | ||
Comment 12•12 years ago
|
||
Filed bug 821942 for test_0113_general.js
Reporter | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbec2ea99d3a
I won't be around to watch the tree until the 18th, so I'll push to aurora and b2g18 then.
Comment 14•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 15•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b8d9a9610558
https://hg.mozilla.org/releases/mozilla-b2g18/rev/a7e5e06a64ed
status-b2g18:
--- → fixed
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
Whiteboard: [automation-needed-in-aurora][automation-needed-in-b2g18]
You need to log in
before you can comment on or make changes to this bug.
Description
•