+++ This bug was initially created as a clone of Bug #772365 +++ (In reply to Brian Smith (:bsmith) from Bug #772365 comment #97) > Created attachment 691721 [details] [diff] [review] > Part 4: Check signature during app installation, diff -w [NOT FOR CHECKIN] > > This is the diff -w version of attachment 691719 [details] [diff] [review]. > With this patch, I can successfully (modulo bugs not related to signing) > install a privileged app from the dev. marketplace. In particular, > https://marketplace-dev.allizom.org/app/privileged-app-test/. > > The actual test app (privileged-app-test) has the following bugs: > > 1. It's manifest wrongly requests "device-storage" instead of > "device-storage:pictures." > 2. The contacts API portion of the test app fails. > 3. The device storage portion of the app doesn't give a visible indication > of passing or failing. > > These issues with the test app should be resolved soon, because the test app > is embedded in the Gecko test suite in part 3.3 of this patch series. I think jsmith said he was going to update the app to fix the bugs, so I am assigning this to him. Once the app is attached here, I will update the copy in the test suite with the new version.

Yeah, I'll look into it.

We wouldn't hold the release for this, so not a blocker. But we obviously need to test the signing code somehow (manual or automated), so whatever needed to make that happen should obviously be worked on.

Here's an updated signed packaged app with a bunch of fixes I've made (including the ones specified). Note that the failure in the contacts api was actually a bug, not a bug in the app.

Redirecting to bsmith now that there's an updated app.

Ryan, I cannot replace the marketplace-dev cert with the marketplace-prod (test) cert until I have the test app signed with the marketplace-prod cert. Could you please sign the cert and attach it to this bug. (blocking-basecamp because it blocks another blocking-basecamp bug.)

(In reply to Brian Smith (:bsmith) from comment #5) > Could you please sign the cert and attach it to this bug. That is, could you please sign the app that jsmith attacked to this bug with the prod cert, and then attach the re-signed version to this bug?

jsmith: do you have an app that passes validation? The one attached fails: http://cl.ly/image/0R1R3j0V1G3G. We need to upload that prod to see if the signing passes.

The Marketplace now requires the app to contain an icon that is at least 128x128, so I had to slightly resize the icon. I also removed META-INF so it could be re-signed. Marketplace prod. is still rejecting the app though because it doesn't accept apps that specify "type" : "privileged" in the manifest.

Lisa, I have attached the new version of the app to this bug. Since marketplace prod won't accept the app as it is because it is "type" : "privileged", could we get the app signed using some other path, and/or push a one-off fix for the "type" : privileged" issue to Marketplace Prod. on Tuesday?

(In reply to Andy McKay [:andym] from comment #7) > jsmith: do you have an app that passes validation? The one attached fails: > http://cl.ly/image/0R1R3j0V1G3G. We need to upload that prod to see if the > signing passes. Yeah. I realized that after attaching this app - the validator changed. I'll add a second attachment with the fixes (took care of this, but didn't update the bug). (In reply to Brian Smith (:bsmith) from comment #8) > Created attachment 698871 [details] > Test app with two bugs fixed > > The Marketplace now requires the app to contain an icon that is at least > 128x128, so I had to slightly resize the icon. I also removed META-INF so it > could be re-signed. > > Marketplace prod. is still rejecting the app though because it doesn't > accept apps that specify "type" : "privileged" in the manifest. That's a bug that I know is fixed on dev, but I'm guessing the fix hasn't been pushed to prod then.

Its alright jsmith we've got it and the app is live, sorry didn't update bug.

Thanks everybody! I update the copy of the app for test_signed_apps-marketplace.js in bug 824199.