Right now telemtry sends flash version information on desktop, but not on Android. It would be nice to have this.

Comment on attachment 692342 [details] [diff] [review] Get some kind of version information into nsPluginTag for Flash on Android Review of attachment 692342 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/base/nsPluginHost.cpp @@ +2947,5 @@ > + // Flash on Android does not populate the version field, but it is tacked on to the description. > + // For example, "Shockwave Flash 11.1 r115" > + if (PL_strncmp("Shockwave Flash ", description, 16) == 0 && description[16]) { > + version = &description[16]; > + description[15] = '\0'; Comment on what you're doing here. Looks like you're cutting the version off of the description field so that it doesn't show up later, but it isn't obvious why you're doing that. I'd recommend not doing it - doesn't seem like potentially messing with compatibility for our previous behavior is worth a slightly cleaner description field.

(In reply to Josh Aas (Mozilla Corporation) from comment #2) > Comment on attachment 692342 [details] [diff] [review] > Get some kind of version information into nsPluginTag for Flash on Android > > Review of attachment 692342 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/plugins/base/nsPluginHost.cpp > @@ +2947,5 @@ > > + // Flash on Android does not populate the version field, but it is tacked on to the description. > > + // For example, "Shockwave Flash 11.1 r115" > > + if (PL_strncmp("Shockwave Flash ", description, 16) == 0 && description[16]) { > > + version = &description[16]; > > + description[15] = '\0'; > > Comment on what you're doing here. Looks like you're cutting the version off > of the description field so that it doesn't show up later, but it isn't > obvious why you're doing that. > > I'd recommend not doing it - doesn't seem like potentially messing with > compatibility for our previous behavior is worth a slightly cleaner > description field. Fair enough. Latest patch only sets the version and leaves the description alone. Carryied the r+ forward.

Comment on attachment 692931 [details] [diff] [review] Get some kind of version information into nsPluginTag for Flash on Android [Approval Request Comment] I want this in Aurora and Beta pronto. Very low risk, gives very useful information about Flash usage in the wild.

Comment on attachment 692931 [details] [diff] [review] Get some kind of version information into nsPluginTag for Flash on Android We like low risk Telemetry fixes, and can back this out before our RC if anything goes awry. Please land on mozilla-beta no later than 12/26 to make it into FF18.

https://hg.mozilla.org/releases/mozilla-aurora/rev/08d1135a7c9a https://hg.mozilla.org/releases/mozilla-beta/rev/070430c74f6c