Closed Bug 821848 Opened 12 years ago Closed 12 years ago

PBM - Cannot find text cursor on location bar in private tab

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 verified, firefox21 verified, firefox22 verified, fennec20+)

Status:
VERIFIED FIXED
Milestone:
Firefox 22
Tracking Flags:
Tracking Status
firefox20 --- verified
firefox21 --- verified
firefox22 --- verified
fennec 20+ ---

People

(Reporter: tetsuharu, Assigned: sriram)

References

Details

Attachments

(1 file)

Patch
(deleted), patch
bnicholson
: review+
bajaj
: approval-mozilla-aurora+
bajaj
: approval-mozilla-beta+
Details | Diff | Splinter Review
Environment: - http://hg.mozilla.org/mozilla-central/rev/b11065872128 - Xperia arc (ICS, sony build) Step to reproduce: 1) Open a private tab. 2) Focus on location bar in the private tab. Result: I cannot find text cursor in location bar. The color of cursor is black, so the cursor is buried in background color.
Blocks: pb
status-firefox20: --- → affected
Component: Text Selection → Theme and Visual Design
Summary: cannot find text cursor on location bar in private tab → PBM - Cannot find text cursor on location bar in private tab
tracking-fennec: --- → ?
tracking-fennec: ? → 20+
Needs a beta assignee
status-firefox22: --- → affected
Attached patch Patch (deleted) — — Splinter Review
This works. Somehow.
Attachment #719608 - Flags: review?(bnicholson)
Attachment #719608 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/78a089f382f9
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment on attachment 719608 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Private Browsing User impact if declined: user unable to "see" the blinking text caret (cursor) in the URLbar when in private browsing mode Testing completed (on m-c, etc.): it's on m-c now Risk to taking this patch (and alternatives if risky): seems low risk String or UUID changes made by this patch: none
Attachment #719608 - Flags: approval-mozilla-beta?
Attachment #719608 - Flags: approval-mozilla-aurora?
Comment on attachment 719608 [details] [diff] [review] Patch Low risk uplift of a minor user annoyance. PLease make sure to land before 3/5(tomorrow) for it to make to FX 20 beta 3(going to build tomorrow)
Attachment #719608 - Flags: approval-mozilla-beta?
Attachment #719608 - Flags: approval-mozilla-beta+
Attachment #719608 - Flags: approval-mozilla-aurora?
Attachment #719608 - Flags: approval-mozilla-aurora+
Looks good on trunk
Status: RESOLVED → VERIFIED
status-firefox22: fixed → verified
Verified on Firefox for Android 21.0b6 using: Nexus 4 (4.2.2)
status-firefox21: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: