Closed
Bug 822422
Opened 12 years ago
Closed 12 years ago
Firefox wordmark barely visible on dark lightweight themes
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox19 verified, firefox20 verified)
VERIFIED
FIXED
Firefox 20
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(2 files)
(deleted),
application/zip
|
Details | |
(deleted),
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The Firefox wordmark is barely visible on dark lightweight themes. We need different set of resources that would work on light and dark themes (in addition to default one).
Assignee | ||
Updated•12 years ago
|
Flags: needinfo?(ibarlow)
Comment 1•12 years ago
|
||
We'll need a white Firefox wordmark for this. CC-ing Eric.
Flags: needinfo?(ibarlow)
Comment 2•12 years ago
|
||
Sized for mdpi, hdpi and xhdpi. let me know if anything else is needed, thx!
Updated•12 years ago
|
Assignee: nobody → sriram
Assignee | ||
Comment 3•12 years ago
|
||
White on dark. Black on light. All good. :D
Attachment #693636 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #693636 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Push backed out for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=18097340&tree=Mozilla-Inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/850b6458a7f0
Please try building locally before pushing! :-)
Assignee | ||
Comment 6•12 years ago
|
||
I had triggered a clobber for the same. It's a clobbering issue.
Assignee | ||
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #6)
> I had triggered a clobber for the same. It's a clobbering issue.
Ah, sorry.
Our mobile build story is so messed up :-(
Assignee | ||
Comment 9•12 years ago
|
||
Tried in try: https://tbpl.mozilla.org/?tree=Try&rev=d340eeb569ff
Assignee | ||
Comment 10•12 years ago
|
||
Comment 11•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Assignee | ||
Comment 12•12 years ago
|
||
Comment on attachment 693636 [details] [diff] [review]
Patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Personas.
User impact if declined: Firefox watermark will be in grey on a dark theme, and barely visible.
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Very low. Just addition of few images in this patch.
String or UUID changes made by this patch: None.
Attachment #693636 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #693636 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•12 years ago
|
||
Firefox 20.0a1 (20123-01-02)
Device: Galaxy Nexus
OS: Android 4.1.1
I can see the white wordmark using the theme : https://addons.mozilla.org/en-US/android/addon/a-festival-of-lights-pink-f/ Bug is verified on Nightly. Please push this to aurora and I will mark this verified after checking it on Firefox 19 too
status-firefox19:
--- → affected
status-firefox20:
--- → fixed
Assignee | ||
Comment 14•12 years ago
|
||
Updated•12 years ago
|
Comment 15•12 years ago
|
||
Firefox 19 Beta 1 (2013-01-08)
Device: Galaxy Nexus
OS:Android 4.1.
This was push in beta channel also as Firefox 19 is currently in Beta. As the wordmark is white now I will mark the bug Verified Fixed.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•