Closed
Bug 822703
Opened 12 years ago
Closed 12 years ago
s/ShutdownTime/TelemetryData/ where appropriate
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
vladan
:
review+
|
Details | Diff | Splinter Review |
In bug 814765 we will be reading more than just the shutdown time, but the extra data (the late write stacks) can reuse exactly the same logic for when to read and how to cache as the shutdown time.
This patch goes on top of 822695 and just renames some fields and methods to reduce the noise on the patch for 814765.
Attachment #693473 -
Flags: review?(vdjeric)
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #693473 -
Attachment is obsolete: true
Attachment #693473 -
Flags: review?(vdjeric)
Attachment #693539 -
Flags: review?(vdjeric)
Comment 2•12 years ago
|
||
Comment on attachment 693539 [details] [diff] [review]
In which I am reminded that doing a build is not enough for JS :-(
As long as we're on the topic of renaming vars, what do you think of changing "Read" to "Fetch" in variable & function names? It seems more clear that we are doing I/O. Just an idea
Attachment #693539 -
Flags: review?(vdjeric) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•