Closed
Bug 822722
Opened 12 years ago
Closed 12 years ago
Dialer - Lazy load the call log related resources
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect, P3)
Tracking
(blocking-basecamp:+)
People
(Reporter: etienne, Assigned: etienne)
References
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
We already have the base mechanism in place, so let's take this 200-300ms win :)
Assignee | ||
Updated•12 years ago
|
Blocks: Dialer-Startup
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #693501 -
Flags: review?(21)
Assignee | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → etienne
Comment 2•12 years ago
|
||
Comment on attachment 693501 [details] [diff] [review]
Patch proposal
Review of attachment 693501 [details] [diff] [review]:
-----------------------------------------------------------------
Close! I just want to make sure the script onload handler is necessary.
::: apps/communications/dialer/js/lazy_l10n.js
@@ -16,4 @@
>
> // Adding the l10n JS files to the DOM
> // the l10n resources
> - var derahs = 'shared'; // Ugly, waiting for bug 822108
\o/
::: apps/communications/dialer/js/recents.js
@@ +160,5 @@
> +
> + scripts.forEach(function scriptIterator(url) {
> + var script = document.createElement('script');
> + script.src = url;
> + script.onload = scriptLoaded;
I think that scripts added dynamically are loaded synchronously. Can you check? That will avoid the need to have a callback on the onload handler.
@@ +166,3 @@
> });
> +
> + this._loaded = true;
Can we keep this line next to the header of the function (next to where it is used).
Attachment #693501 -
Flags: review?(21)
Assignee | ||
Comment 3•12 years ago
|
||
Comments addressed and telephony bug avoid. \o/
Attachment #693501 -
Attachment is obsolete: true
Attachment #694865 -
Flags: review?(21)
Attachment #694865 -
Flags: review?(21) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•