Assertion failure: GetDirectionFromText(child->GetText()) == eDir_NotSet (Strong directional characters before aStartAfterNode), at content/base/src/DirectionalityUtils.cpp:375

We need to be consistent about which text nodes we look at in the loop in WalkDescendantsSetDirectionFromText and the #ifdef DEBUG pre-loop which looks for text nodes with strong directional characters before aStartAfterNode. Otherwise we get false positives like this. In the testcase there *is* a strong directional character before aStartAfterNode, but it's a descendant of a node with dir=ltr, so it doesn't set the direction of the ancestor div with dir="auto".

Comment on attachment 693782 [details] [diff] [review] Patch Review of attachment 693782 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/base/src/DirectionalityUtils.cpp @@ +382,5 @@ > + // of their ancestors > + if (child->IsElement() && > + (DoesNotParticipateInAutoDirection(child->AsElement()) || > + child->NodeInfo()->Equals(nsGkAtoms::bdi) || > + child->HasFixedDir())) { Hmm, I think we need to add a utility method for this. Can you please file a follow-up?