Closed Bug 82274 Opened 23 years ago Closed 23 years ago

XPCJSRuntime leaks mDyingWrappedNativeProtoMap

Categories

(Core :: XPConnect, defect)

x86
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: dbradley)

Details

(Keywords: memory-leak)

Attachments

(3 files)

According to the Boehm GC, the XPCJSRuntime leaks its mDyingWrappedNativeProtoMap (because it's not |delete|-ed in the destructor, I presume).
Keywords: mlk
John, I assume it just needs the delete added like the rest of the maps? I'll attach a patch for the additional code. Let me know if there is something conceptually wrong with delete this here. I seem to remember some discussions surround the dying prototypes map before, but don't remember the specifics.
Status: NEW → ASSIGNED
r/sr=jband Two nits... - Please make patches from the closest directory to the files which will compose the patch. In this case mozilla/js/src/xpconnect/src. If you needed to make a patch of files in xpconnect/idl and xpconnect/src together then you'd build the patch from mozilla/js/src/xpconnect. This makes it easier for all. - Like it or not you are inheriting code with a particular style. Our most overriding sytle rule is to maintain the consistency of the style in place in any particular file. Specifically here, no space between 'if' and '('. Please fix that in your change.
Attached patch ! Missed an if (deleted) — Splinter Review
dbradley's patches checked in as part of fix for bug 84020
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Marking Verified -
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: