Closed
Bug 823001
Opened 12 years ago
Closed 12 years ago
B2G STK: STK Set-Up menu doesn't work properly
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P2)
Tracking
(blocking-basecamp:+)
People
(Reporter: mbarone976, Assigned: frsela)
References
Details
(Keywords: regression, Whiteboard: testrun 4)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
Gecko: cb6ee76
Gaia: 16006ea
Precondition: To perform this test you need the SIM toolkit Kit with the SIM number 3
STR
1. Introduce the SIM number 3
2. In settings go to SIM Toolkit option
3. Click on Movistar
4. Click on Primero (same behavior using the option Segundo)
EXPECTED RESULT
The item must be selected correctly
ACTUAL RESULT
Nothing happens
Comment 1•12 years ago
|
||
dpv, can you check it is a certification blocker and if so link to the corresponding bug? If it is a blocker, can we check for extra-information about when this command is used?
Updated•12 years ago
|
Flags: needinfo?(dpv)
Comment 2•12 years ago
|
||
Hi,
Yes, this would be a blocker issue, as it's a quite necessary STK functionality (basic for accessing to STK menus).
You can find more details in:
GSM Spec 11.14:
http://www.ttfn.net/techno/smartcards/GSM11-14V5-2-0.pdf
'The SIM shall supply a set of menu items, which shall be integrated with the menu system (or other MMI facility) in order to give the user the opportunity to choose one of these menu items at his own discretion. Each item comprises a short identifier (used to indicate the selection) and a text string. The SIM shall
include an alpha identifier which acts as a title for the list of menu items.'
We add also the dependency with meta certification bug.
Please, take into account that this could be a regression, as it was working with previous builds. This issue prevents the execution of almost all STK tests.
If you need any further info, please, let us know.
Blocks: b2g-v1-certification
Flags: needinfo?(dpv)
Updated•12 years ago
|
blocking-basecamp: ? → +
Keywords: regression
Priority: -- → P2
Target Milestone: --- → B2G C3 (12dec-1jan)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → frsela
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #694327 -
Flags: review?(21)
Comment 4•12 years ago
|
||
Comment on attachment 694327 [details] [diff] [review]
Added displayTextTimeout const used in displayText method
Review of attachment 694327 [details] [diff] [review]:
-----------------------------------------------------------------
::: apps/settings/js/icc.js
@@ +17,5 @@
> var iccLastCommand = null;
> var iccLastCommandProcessed = false;
> var stkOpenAppName = null;
> var stkLastSelectedTest = null;
> + var displayTextTimeout = 10000;
Why 10000? I usually don't like timeout value like this but if there a good explanation I can change my mind.
Attachment #694327 -
Flags: review?(21)
Assignee | ||
Comment 5•12 years ago
|
||
The STK specs says that if no userClear is provided, the dialog SHALL be automatically closed after a conservative time (to allow user to read notification).
I set it to 10secs. since I think is a good compromise. Anyway, if you suggest a better way to autoclose the dialog let me know ;)
Assignee | ||
Comment 6•12 years ago
|
||
I added a new settings parameter so this timeout can be configurable. I maintained the const 10000 as a default value.
Attachment #694327 -
Attachment is obsolete: true
Attachment #694718 -
Flags: review?(21)
Assignee | ||
Comment 7•12 years ago
|
||
Sorry I uploaded an incremental patch, not complete one. This fix previous commit ;)
Attachment #694718 -
Attachment is obsolete: true
Attachment #694718 -
Flags: review?(21)
Attachment #694720 -
Flags: review?(21)
Attachment #694720 -
Flags: review?(21) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Landed:
PR: https://github.com/mozilla-b2g/gaia/pull/7167
Commit: https://github.com/mozilla-b2g/gaia/commit/7c07c4bf026f7efa4eb876eb5eee202044a83f1c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: testrun 4
You need to log in
before you can comment on or make changes to this bug.
Description
•