Closed
Bug 823226
Opened 12 years ago
Closed 12 years ago
Add environment variables to control cycle collector logging
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → continuation
|
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #694083 -
Flags: review?
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 694083 [details] [diff] [review]
convert form globals to reading from environment variables
Suggestions welcome on env var names. No hurry on this review, as I'm on holiday until the 26th or so.
Attachment #694083 -
Flags: review? → review?(bugs)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 694083 [details] [diff] [review]
convert form globals to reading from environment variables
> nsCycleCollectorParams() :
>+ mLogAll (PR_GetEnv("XPCOM_CC_LOG_ALL") != NULL),
>+ mLogShutdown (PR_GetEnv("XPCOM_CC_LOG_SHUTDOWN") != NULL),
>+ mAllTracesAtShutdown (PR_GetEnv("XPCOM_CC_ALL_TRACES_AT_SHUTDOWN") != NULL),
!= NULL is not pretty but let's fix coding style elsewhere.
Attachment #694083 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d29b182e169e
This page should probably be updated:
https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump
Really, heap dumping needs to be documented separately. There's a page around somewhere.
Keywords: dev-doc-needed
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•