Closed Bug 823397 Opened 12 years ago Closed 12 years ago

Installing a privileged app from marketplace dev - appStatus should be privileged, but ends up being web

Categories

(Core Graveyard :: DOM: Apps, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

VERIFIED FIXED
mozilla20
blocking-basecamp +
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: jsmith, Assigned: gwagner)

References

Details

Attachments

(3 files, 1 obsolete file)

Build: B2G 18 12/20/2012 Device: Unagi Steps: 1. Install https://marketplace-dev.allizom.org/app/new-privileged-app 2. Run adb shell cat /data/local/webapps/webapps.json on your device and find the app you just installed Expected: The appStatus should be privileged. Actual: The appStatus ends up being web. This implies that signing failed somewhere.
blocking-basecamp: --- → ?
Attached file Test App (deleted) —
{ "version": "1.1", "name": "New Privileged App", "description": "A different privileged app", "launch_path": "/privilegedapp.html", "icons": { "126": "/qalogo.png" }, "type": "privileged", "permissions": { "device-storage:pictures": { "access": "readwrite", "description": "Come see my device storage" }, "contacts": { "access": "readwrite", "description": "Come see my contacts" } }, "developer": { "name": "Mozilla QA", "url": "http://quality.mozilla.org" } }
Attached file Webapps JSON (obsolete) (deleted) —
Comment on attachment 694237 [details] Webapps JSON Attached the wrong json file. Let me fix this...
Attachment #694237 - Attachment is obsolete: true
Attached file Webapps JSON (deleted) —
Here is the right one
Assignee: nobody → fabrice
blocking-basecamp: ? → +
Hmm...I don't think that I regressed anything in bug 772365, given how minimal my changes to the installPackage implementation were. I think it is likely that we just never set the app status and always left it at 1 (web), or we regressed doing that somewhere else.
Attached patch patch (deleted) — Splinter Review
Since I already had my debug statements in place :)
Assignee: fabrice → anygregor
Attachment #694453 - Flags: review?(fabrice)
I think I have a fix, but I can't get the app attached here to install from a local test server. Which certificate should I have on my phone?
Comment on attachment 694453 [details] [diff] [review] patch Review of attachment 694453 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Gregor!
Attachment #694453 - Flags: review?(fabrice) → review+
(In reply to Fabrice Desré [:fabrice] from comment #8) > I think I have a fix, but I can't get the app attached here to install from > a local test server. Which certificate should I have on my phone? Assuming the app came from marketplace-dev, that cert is Gecko's security/build/b2g-app-root-cert.der
Blocks: 823224
I verified that with this patch appStatus == 2 for https://marketplace-dev.allizom.org/app/new-privileged-app
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Keywords: verifyme
QA Contact: jsmith
Verified on 12/28 build with installing some privileged apps on dev and verifying the app status was 2.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: