Closed
Bug 823986
Opened 12 years ago
Closed 12 years ago
[Wrapper] double tapping home button will show the wrapper around the homescreen
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect, P3)
Tracking
(blocking-basecamp:+)
People
(Reporter: tchung, Assigned: vingtetun)
References
Details
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
crdlc
:
review+
|
Details | Diff | Splinter Review |
You can get the browser wrapper to wrap around the homescreen and any core apps. This is caused after trying to double tap home button when a e.me app (or browser bookmark) is open
Screenshot.
Repro:
1) install nightly unagi build, 20121220092540
2) add a browser bookmark or e.me app to the homescreen
3) launch that bookmark or e.me app
4) double tap the system Home button.
5) Verify app exits, and the homescreen is within the wrapper
Expected;
- double tapping should kill the wrapper as well
Actusl;
- wrapper stays. you can proceed with using the phone within the wrapper.
Updated•12 years ago
|
Assignee: nobody → alive
Comment 1•12 years ago
|
||
Triage: BB-.P4, tracking-b2g18+.
should not block if this were the last bug before ship. doesn't block usage
Reporter | ||
Comment 2•12 years ago
|
||
I'm going to renominate this bug for bb? triage. this is easily reproducible, and all sorts of weird things happen once you're in the wrapper. For example, overlays are getting confused which to focus on, and more frequent crashes occur within e.me apps that is affecting the entire homescreen.
josh also tells me that e.me guys are here this week, and might be able to look at it.
blocking-basecamp: - → ?
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Tony Chung [:tchung] from comment #2)
> I'm going to renominate this bug for bb? triage. this is easily
> reproducible, and all sorts of weird things happen once you're in the
> wrapper. For example, overlays are getting confused which to focus on, and
> more frequent crashes occur within e.me apps that is affecting the entire
> homescreen.
>
> josh also tells me that e.me guys are here this week, and might be able to
> look at it.
Ignore this comment, its probably more a benfrancis question, since its not just e.me apps, but also affects browser bookmarks on homescreen.
Comment 4•12 years ago
|
||
This is a bug in system app window manager I believe ;) not e.me
(In reply to Tony Chung [:tchung] from comment #3)
> (In reply to Tony Chung [:tchung] from comment #2)
> > I'm going to renominate this bug for bb? triage. this is easily
> > reproducible, and all sorts of weird things happen once you're in the
> > wrapper. For example, overlays are getting confused which to focus on, and
> > more frequent crashes occur within e.me apps that is affecting the entire
> > homescreen.
> >
> > josh also tells me that e.me guys are here this week, and might be able to
> > look at it.
>
> Ignore this comment, its probably more a benfrancis question, since its not
> just e.me apps, but also affects browser bookmarks on homescreen.
related to fix from bug 799497? I had a similar bug reported but it was placed as a dup of bug 799497.
Updated•12 years ago
|
blocking-basecamp: ? → +
tracking-b2g18:
+ → ---
Priority: P4 → P3
Target Milestone: --- → B2G C4 (2jan on)
Updated•12 years ago
|
QA Contact: ben
Updated•12 years ago
|
Assignee: alive → ben
QA Contact: ben
Assignee | ||
Comment 7•12 years ago
|
||
When you double click on the home button the window manager code calls a new setDisplayedApp(homescreen) if a transition is currently happening which results into an instantaneous stop of the transition. That's not bad but since the wrapper buttons are hidden only at the end of the transition under a transitionend event that does not work in this case. The patch simply moves the removal out of the transitionend path which is not done for the wrapper anyway.
Attachment #699185 -
Flags: review?(crdlc)
Comment 8•12 years ago
|
||
please give me the branch to test, thanks
Comment 9•12 years ago
|
||
Comment on attachment 699185 [details] [diff] [review]
Patch
It is perfect because I remember the problem :) thanks a lot Vivien!!!!
Attachment #699185 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•