Closed
Bug 824044
Opened 12 years ago
Closed 12 years ago
Homescreen bustage
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fabrice, Assigned: Margaret)
Details
Attachments
(1 file)
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
E/GeckoConsole( 7534): [JavaScript Error: "SyntaxError: missing ( after for" {file: "app://homescreen.gaiamobile.org/js/grid.js" line: 349 column: 8 source: " for each (var iconsForApp in appIcons) {
E/GeckoConsole( 7534): "}]
E/GeckoConsole( 7534): [JavaScript Error: "ReferenceError: GridManager is not defined" {file: "app://homescreen.gaiamobile.org/js/dragdrop.js" line: 27}]
E/GeckoConsole( 7534): [JavaScript Error: "ReferenceError: GridManager is not defined" {file: "app://homescreen.gaiamobile.org/js/homescreen.js" line: 16}]
Reporter | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Assignee | ||
Comment 1•12 years ago
|
||
for each...in is deprecated: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Statements/for_each...in
I'll write a patch to stop using it.
Assignee: nobody → margaret.leibovic
Assignee | ||
Comment 2•12 years ago
|
||
Hm, Fabrice, what gecko were you running that led to this problem? I can't actually reproduce the error on today's mozilla-b2g18 on my phone, or on the latest mozilla-central B2G desktop (I don't have a current m-c build for my phone).
I can still write a patch to fix this, but I'm curious why I'm not seeing the problem. Also, I searched Gaia, and we also use for each...in in one place in browser/js/browser.js, so we should probably fix that as well.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #694971 -
Flags: review?(fabrice)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 694971 [details] [diff] [review]
Replace for each...in with for...in in grid.js
Review of attachment 694971 [details] [diff] [review]:
-----------------------------------------------------------------
r=a=me
Attachment #694971 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/5aafc8832854b26d9dc50163e9a785f177a69dc2
I filed bug 824101 about removing for each...in in browser.js. But I'm still curious why this only caused errors now.
Status: NEW → RESOLVED
blocking-basecamp: ? → ---
Closed: 12 years ago
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=804834 Related I think.
(In reply to Margaret Leibovic [:margaret] from comment #5)
> https://github.com/mozilla-b2g/gaia/commit/
> 5aafc8832854b26d9dc50163e9a785f177a69dc2
>
> I filed bug 824101 about removing for each...in in browser.js. But I'm still
> curious why this only caused errors now.
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Alive Kuo [:alive] from comment #6)
> https://bugzilla.mozilla.org/show_bug.cgi?id=804834 Related I think.
Good catch. This sounds like exactly what caused this problem.
You need to log in
before you can comment on or make changes to this bug.
Description
•