Closed
Bug 824132
Opened 12 years ago
Closed 12 years ago
Avoid resetting the theme on startup
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox19 fixed, firefox20 fixed)
RESOLVED
FIXED
Firefox 20
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When Gecko starts, if there is no theme, it sends a reset-theme message. This will cause all the registered views to set its own background again. This is unnecessary. We could use a state variable to monitor this -- just so to reset only if a theme is enabled.
|
Assignee | |
Comment 1•12 years ago
|
||
This ensures reset is called only if it is ever set.
Attachment #695038 -
Flags: review?(mark.finkle)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 695038 [details] [diff] [review]
Patch
This is OK, but could we use mBitmap as the "state"? If mBitmap is null, the theme is not enabled. If mBitmap is not null then the theme is enabled.
If we can use mBitmap, let's do it. If the boolean is better, I'm OK with it.
Attachment #695038 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed with mBitmap as the state:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30607c0b98c2
|
||
Comment 4•12 years ago
|
||
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 695038 [details] [diff] [review]
Patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Optimization.
User impact if declined: None.
Testing completed (on m-c, etc.): Landed in m-c on 12/27
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.
(This patch is required for Bug 816114).
Attachment #695038 -
Flags: approval-mozilla-aurora?
|
||
Updated•12 years ago
|
Attachment #695038 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Updated•12 years ago
|
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•