Please check the bug 804667 comment #20. ::: dom/system/gonk/ril_worker.js @@ +3178,5 @@ > + let timer = response.timer; > + size = size + > + ((timer.timerId ? TLV_TIMER_IDENTIFIER : 0) + > + (timer.timerValue ? TLV_TIMER_VALUE : 0)) * 2; > + } Maybe we could do as sendICCEnvelopeCommand, so we don't have to do '* 2' each time when we add a new TLV.

Comment on attachment 695100 [details] [diff] [review] Refactor the TLV size handler in sendStkTerminalResponse, v1 Review of attachment 695100 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +3395,3 @@ > if (response.localInfo) { > let localInfo = response.localInfo; > + berLen = berLen + seems += is easier @@ +3406,1 @@ > } Add an extra line here. @@ +3406,4 @@ > } > if (response.timer) { > let timer = response.timer; > + berLen = berLen + ditto @@ +3407,5 @@ > if (response.timer) { > let timer = response.timer; > + berLen = berLen + > + (timer.timerId ? TLV_TIMER_IDENTIFIER : 0) + > + (timer.timerValue ? TLV_TIMER_VALUE : 0); Can any one of these two be optional? seems berLen += TLV_TIMER_SIZE; should do the work. where TLV_TIMER_SIZE is TLV_TIMER_IDENTFIER + TLV_TIMER_VAUE

Comment on attachment 695100 [details] [diff] [review] Refactor the TLV size handler in sendStkTerminalResponse, v1 Review of attachment 695100 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +3407,5 @@ > if (response.timer) { > let timer = response.timer; > + berLen = berLen + > + (timer.timerId ? TLV_TIMER_IDENTIFIER : 0) + > + (timer.timerValue ? TLV_TIMER_VALUE : 0); timerValue is optional. For below two action, it needs pass timer value to UICC. - STK_TIMER_DEACTIVE - STK_TIMER_GET_CURRENT_VALUE But STK_TIMER_START needs not.

Address review comment #2

try server: https://tbpl.mozilla.org/?tree=Try&rev=bfb3a21dd38a

Please merge bug 804667 into b2g18 first then this, or may have conflict.

Not sure how I can verify this... Is there some way to easily verify this?

Hi, Naoki This patch is refactoring about the PDU format for STK. So if this patch works, you can navigator through STK menu successfully. Step: Go into Sim Toolkit Menu, and select some item, if some sub-menu pop up, then it's success.

Cannot verify, don't have access to SIM Toolkit.