Closed Bug 824357 Opened 12 years ago Closed 12 years ago

Change mochitests to expect correct behavior

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED DUPLICATE of bug 796890

People

(Reporter: ekr, Assigned: ekr)

Details

(Whiteboard: [WebRTC], [blocking-webrtc+])

Attachments

(1 file)

No description provided.
Comment on attachment 695313 [details] [diff] [review] Change mochitests to expect correct behavior Review of attachment 695313 [details] [diff] [review]: ----------------------------------------------------------------- Now that Adam has fixed the issues that these tests were reporting errors on, we need to change todo_is to is. The following test passes but disturbs me. is(test_data.pcLocal.video[0], pcLocal.remoteStreams[0], "Remote stream for local peer is accessible"); is(test_data.pcRemote.video[0], pcRemote.remoteStreams[0], "Remote stream for remote peer is accessible"); This sure looks like it is testing the equality of two objects which have no reason to be equal. At minimum a comment is needed here.
Attachment #695313 - Flags: review?(hskupin)
Attachment #695313 - Flags: review?(rjesup)
Fix the indentation.
Priority: -- → P2
Whiteboard: [WebRTC], [blocking-webrtc+]
Comment on attachment 695313 [details] [diff] [review] Change mochitests to expect correct behavior While this is the right thing to do, those changes were already part of my patch on bug 796890, which is now on inbound and should have been landed as indicated at the same time with Adam's fix. This patch is not necessary anymore.
Attachment #695313 - Flags: review?(rjesup)
Attachment #695313 - Flags: review?(hskupin)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: