Closed
Bug 824357
Opened 12 years ago
Closed 12 years ago
Change mochitests to expect correct behavior
Categories
(Core :: WebRTC, defect, P2)
Core
WebRTC
Tracking
()
RESOLVED
DUPLICATE
of bug 796890
People
(Reporter: ekr, Assigned: ekr)
Details
(Whiteboard: [WebRTC], [blocking-webrtc+])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 695313 [details] [diff] [review]
Change mochitests to expect correct behavior
Review of attachment 695313 [details] [diff] [review]:
-----------------------------------------------------------------
Now that Adam has fixed the issues that these tests were reporting errors on, we need to change todo_is to is.
The following test passes but disturbs me.
is(test_data.pcLocal.video[0], pcLocal.remoteStreams[0],
"Remote stream for local peer is accessible");
is(test_data.pcRemote.video[0], pcRemote.remoteStreams[0],
"Remote stream for remote peer is accessible");
This sure looks like it is testing the equality of two objects which have no reason to be
equal. At minimum a comment is needed here.
Attachment #695313 -
Flags: review?(hskupin)
Assignee | ||
Updated•12 years ago
|
Attachment #695313 -
Flags: review?(rjesup)
Comment 3•12 years ago
|
||
Fix the indentation.
Updated•12 years ago
|
Priority: -- → P2
Whiteboard: [WebRTC], [blocking-webrtc+]
Comment 4•12 years ago
|
||
Comment on attachment 695313 [details] [diff] [review]
Change mochitests to expect correct behavior
While this is the right thing to do, those changes were already part of my patch on bug 796890, which is now on inbound and should have been landed as indicated at the same time with Adam's fix. This patch is not necessary anymore.
Attachment #695313 -
Flags: review?(rjesup)
Attachment #695313 -
Flags: review?(hskupin)
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•