Closed
Bug 824469
Opened 12 years ago
Closed 12 years ago
"+" button should open new private tab when selected "private" column
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 20
People
(Reporter: yukikeiichi, Assigned: sriram)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Build: Firefox for Android 20.0a1(2012-12-24)
Device: Samsung Galaxy Nexus
OS: Android 4.2.1
Steps to reproduce:
1. Open tabs-tray
2. Select "private" column
3. Tap "+" button
Actual result:
- Open new (normal) tab.
Expected result:
- Open private tab.
|
||
Updated•12 years ago
|
|
||
Updated•12 years ago
|
Flags: needinfo?(ibarlow)
|
|
||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 1•12 years ago
|
||
That's correct, when private tabs are open, the + should open a private tab.
Flags: needinfo?(ibarlow)
|
Assignee | |
Comment 2•12 years ago
|
||
Do we have the same "+" button for both sections? Or the mask in case of private-tabs?
|
|
Assignee | |
Comment 3•12 years ago
|
||
This uses the same "+" button to open normal/private tab depending on the section.
Attachment #697121 -
Flags: review?(mark.finkle)
|
||
Updated•12 years ago
|
Attachment #697121 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Oops.
This patch takes care of the remote tabs too. (4 lines extra over the previous patch).
Attachment #697121 -
Attachment is obsolete: true
Attachment #697125 -
Flags: review?(mark.finkle)
|
|
||
Updated•12 years ago
|
Attachment #697125 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Comment 7•12 years ago
|
||
Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-17)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•