properly enable / disable "File | Offline | Get [Selected / Flagged] Messages" spun off of #79104 we'd do this in the oncreate for that menupopup. I'm not sure if there is an efficient way to know if a folder has any flagged messages. that could be why 4.x always had get flagged messages enabled. (just a guess)

assigning myself.

Mohan is taking it

bienvenu, 1. we need to check whether a folder has flagged/selected messages or not 2. we need a folder property/function for current folder (may be a property of nsIMsgFolder) right ?

We're going to do what 4.x does - enable/disable get selected based on selection, which you already have access to, and always enable Get Flagged.

does this patch check if any messages are selected before enabling/disabling GetSelected Messages? I don't see that it does. The flagged part looks OK.

PDT+ per 6/12 mtg.

r=bienvenu for that second patch.

cc'ing sspitzer for super review;

Unload sspitzer and racham. r=hwaara. bienvenu's r= is sufficent for sr=, so you only need a= now.

Mohan, did you email drivers@mozilla.org and CC the pdt? I don't see a request for a= for this bug in my email (although it may be somewhere I didn't expect it.) If you did not send this email, the a= might take a while to appear...

a= asa@mozilla.org for checkin to 0.9.2. (on behalf of drivers)

This is a 0.9.2 bug. What's the status on getting this checked in?

pushing out. 0.9.2 is done. (querying for this string will get you the list of the 0.9.2 bugs I moved to 0.9.3)

Removing PDT+, marking nsbranch; should be checked into the 0.9.3 trunk ASAP, tested & verified, then submitted for limbo builds.

Fix checked in on behalf on mohanb.

Adding vtrunk; bugs need to be verified in the trunk for eventual limbo checkins.

Clearing resolution, nsBranch bugs should be closed only after checkins into limbo builds.

Commercial builds 2001-07-05-09-trunk/ win nt 4.0 2001-07-05-08-trunk/ linux 2.2, red hat 7.0 2001-07-05-08-trunk/ mac os 9.0.4 Verified the following: * File|Offline|Get Flagged Messages -if online, it's always available whether a message is flagged or not -if message(s) is/are flagged, then they are downloaded * File|Offline|Get Selected Messages -Enabled * if messages are selected and messages that are selected do get downloaded -Disabled * if no messages are selected * Get Flagged/Selected Messages are disabled if you are offline Verified on trunk. Removing Keyword Vtrunk. adding 'verified on trunk' to status whiteboard. Leaving status as Assigned per instructions from Jussi.

Missed 0.9.3.

changing the resolution to fixed, since it is checked into the trunk;

Commercial trunk builds 2001082803 - win nt 4.0 2001082808 - linux 2.2, mac 9.0.4 Verified the following: * File|Offline|Get Flagged Messages -if online, it's always available whether a message is flagged or not -if message(s) is/are flagged, then they are downloaded * File|Offline|Get Selected Messages -Enabled * if messages are selected. The messages that are selected do get downloaded -Disabled * if no messages are selected * Get Flagged/Selected Messages are disabled if you are offline