Closed
Bug 824742
Opened 12 years ago
Closed 12 years ago
NSPR shouldn't require librt
Categories
(NSPR :: NSPR, defect, P1)
NSPR
NSPR
Tracking
(Not tracked)
RESOLVED
FIXED
4.9.5
People
(Reporter: bholley, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This breaks x86 B2G emulator-x86 builds. Glandium says that this shouldn't be there - there's no librt on android.
|
Reporter | |
Comment 1•12 years ago
|
||
This fixes it for me. No idea if it's correct.
Attachment #695786 -
Flags: feedback?(mh+mozilla)
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 695786 [details] [diff] [review]
patch v1
Review of attachment 695786 [details] [diff] [review]:
-----------------------------------------------------------------
I guess the right fix would be to test where clock_gettime can be found, like in gecko configure.in, and use that.
But sure enough, that should work, too.
Attachment #695786 -
Flags: feedback?(mh+mozilla)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #695786 -
Flags: review?(wtc)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 695786 [details] [diff] [review]
patch v1
In fact, I have the opposite problem on GNU/kfreebsd, so it would just be better to import the test from m-c. I'll do it.
Attachment #695786 -
Flags: review?(wtc)
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #3)
> Comment on attachment 695786 [details] [diff] [review]
> patch v1
>
> In fact, I have the opposite problem on GNU/kfreebsd, so it would just be
> better to import the test from m-c. I'll do it.
In fact, that opens a too big can of worms :(
|
|
Assignee | |
Comment 5•12 years ago
|
||
For wtc or ted, whoever comes here first.
Attachment #696475 -
Flags: review?(wtc)
Attachment #696475 -
Flags: review?(ted)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: wtc → mh+mozilla
|
|
Assignee | |
Updated•12 years ago
|
Attachment #695786 -
Attachment is obsolete: true
|
||
Updated•12 years ago
|
Attachment #696475 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Comment on attachment 696475 [details] [diff] [review]
Use -lrt appropriately (or not) on Android, GNU/Hurd and GNU/kFreeBSD
Ted, could you land this on nspr trunk?
Attachment #696475 -
Flags: review?(wtc)
|
|
||
Comment 7•12 years ago
|
||
Checking in pr/src/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/Makefile.in,v <-- Makefile.in
new revision: 1.65; previous revision: 1.64
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Version: other → 4.9.5
|
||
Updated•12 years ago
|
Priority: -- → P1
Target Milestone: --- → 4.9.5
Version: 4.9.5 → other
You need to log in
before you can comment on or make changes to this bug.
Description
•