Closed
Bug 824784
Opened 12 years ago
Closed 11 years ago
Refactor SocialToolbar.updateButton to multiple smaller functions
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jaws, Unassigned)
Details
(In reply to Matthew N. [:MattN] from bug 811835 comment #16)
> ::: browser/base/content/browser-social.js
> @@ +780,5 @@
> > this.updateButtonHiddenState();
> > let provider = Social.provider;
> > let icons = provider.ambientNotificationIcons;
> > let iconNames = Object.keys(icons);
> > + let socialToolbarItem = document.getElementById("social-toolbar-item");
>
> This function is way too large. It should be refactored into more
> manageable pieces in a separate bug.
|
||
Comment 1•11 years ago
|
||
obsoleted by bug 935640
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•