Closed
Bug 82497
Opened 24 years ago
Closed 23 years ago
Stranded Params
Categories
(Bugzilla :: Bugzilla-General, defect, P4)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: jacob, Assigned: jacob)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
In the course of fixing bug 71552 it came up that when a Param is removed from defparam.pl it never gets removed from data/params. While this shouldn't cause an problems, it is extra and unneeded stuff floating around. There should be a routine in checksetup.pl that can remove those. Right now the params the need removing are: * newemailtech * newemailtechdefault * changedmail * prettyasciimail Attachment 33631 [details] has the routines that would need to be added to checksetup.pl. There was a question on IRC how requiring defparams.pl would react w/out having globals.pl for the SendSQL routine (even though SendSQL is inside a sub that isn't called by WriteParams).
Comment 1•24 years ago
|
||
other params that are stranded: * nummilestones * curmilestone those are handled on a per-product basis now.
Comment 2•24 years ago
|
||
By stranded by we mean removed from editparams.cgi but still elsewhere? Cause Dave's params were still on editparams.cgi last time I looked.
Comment 3•24 years ago
|
||
by stranded, we mean they're still in editparams.cgi, but nothing anywhere in Bugzilla uses them. Or more accurately, they're still in data/params, since editparams.cgi just reads in data/params and defparams.pl and outputs the results.
Updated•24 years ago
|
Target Milestone: --- → Bugzilla 2.14
Comment 4•24 years ago
|
||
The sanitycheck.cgi script could destrand params :) Not critical for 2.14 since it has been this way for a long time, might want to relnote it though. Anyone mind if we make this 2.16?
Target Milestone: Bugzilla 2.14 → Bugzilla 2.16
Assignee | ||
Comment 5•24 years ago
|
||
Assignee | ||
Comment 6•24 years ago
|
||
I was thinking about this the other day and came up with the idea that instead of adding the support for checksetup.pl to delete params, it might be better to just make WriteParams() delete any param that isn't defined in defparams.pl. Then in order to remove a param, all you need to do is delete the definition out of defparams.pl (which you have to do anyway so it doesn't show up on editparams.cgi)
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
The second patch is to remove 'nummilestones' from defparams.pl. 'curmilestone' is still used inside of reports.cgi (I'd say it's a good bet that it's not used sucessfully, but removing it from defparams.pl while it's still in reports.cgi can have some bad side effects (like 'die "Can't find param named $value";').
Comment 9•23 years ago
|
||
I thought reports uses the product "defaultmilestone" field.
Priority: -- → P4
Comment 10•23 years ago
|
||
See also bug #65383. Not sure if we should close that one out. We should definitely fix reports for 2.16.
Severity: normal → trivial
Assignee | ||
Comment 11•23 years ago
|
||
Also in the "defparams.pl but nowhere else" are all the despot params (usedespot and the like). So if we aren't going to hack in despot support (which I don't think we are) we should remove those params.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•23 years ago
|
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: Bugzilla 2.12 → 2.12
Comment 12•23 years ago
|
||
I'm not sure I agree with this. These could be useful if people want to roll back.
Comment 13•23 years ago
|
||
Matthew has a fair point. Are they actually doing any _harm_ (presuming we don't want to reuse a param name)? Gerv
Comment 14•23 years ago
|
||
We are currently trying to wrap up Bugzilla 2.16. We are now close enough to release time that anything that wasn't already ranked at P1 isn't going to make the cut. Thus this is being retargetted at 2.18. If you strongly disagree with this retargetting, please comment, however, be aware that we only have about 2 weeks left to review and test anything at this point, and we intend to devote this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18
Comment 15•23 years ago
|
||
Done as part of bug 104521.
Comment 16•23 years ago
|
||
Bug 126571 is about a bug in the implementation of this fix.
Comment 17•23 years ago
|
||
fixing incorrect milestones on fixed bugs.
Target Milestone: Bugzilla 2.18 → Bugzilla 2.16
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•