Closed Bug 825052 Opened 12 years ago Closed 12 years ago

browser.js uses for each loop which is removed in latest m-c

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: djf, Unassigned)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(1 file)

browser.js uses the non-standard "for each" loop in handleClearHistory(). "for each" has recently been removed by bug 804834 and in m-c builds today the browser app does not work because of this.
Attached file link to patch on github (deleted) —
Attachment #696117 - Flags: review?(dale)
Attachment #696117 - Flags: review?(dale) → review+
Comment on attachment 696117 [details] link to patch on github Dale, I've fixed the nearby bug with the undefined tabId identifier. But it looks like the bug was deeper... There were multiple closures created in a for loop, so the tabId value would change before the nested callback function would be invoked. So I had to restructure the code to use Object.keys(this.tabs).forEach() instead of a for in loop. So I'm asking for another review before landing it.
Attachment #696117 - Flags: review+ → review?(dale)
Dale, The main reason I need more review on this is that I don't know what self.refreshButtons() is supposed to do, so I can't tell if it is getting called appropriately.
Comment on attachment 696117 [details] link to patch on github Fix is good, merged in: https://github.com/mozilla-b2g/gaia/commit/12b722515af8df6eabad59ac8ecd19d8b0b24734 Just for reference sake, the buttons are refreshed as the history of all tabs including the currently visible one is removed, meaning the user cannot go back / forwards
Attachment #696117 - Flags: review?(dale) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: