Closed
Bug 825295
Opened 12 years ago
Closed 12 years ago
Make the in-content downloads view show only private downloads when opened in a private browsing window
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
VERIFIED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
We need to make sure that this view only shows private downloads. This is a follow-up from bug 815352, and will finish the work to support the downloads panel UI in private windows.
|
Assignee | |
Comment 1•12 years ago
|
||
We just need to make sure not to display places downloads in private windows. Everything else works correctly.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #696533 -
Flags: review?(mconley)
Attachment #696533 -
Flags: review?(mano)
Attachment #696533 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 696533 [details] [diff] [review]
Patch (v1)
Dao, I'd appreciate if you can review this.
Attachment #696533 -
Flags: review?(dao)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 696533 [details] [diff] [review]
Patch (v1)
I assume a window cannot be moved out of private browsing mode.
Attachment #696533 -
Flags: review?(mconley)
Attachment #696533 -
Flags: review?(mano)
Attachment #696533 -
Flags: review?(mak77)
Attachment #696533 -
Flags: review?(dao)
Attachment #696533 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to Mano from comment #3)
> Comment on attachment 696533 [details] [diff] [review]
> Patch (v1)
>
> I assume a window cannot be moved out of private browsing mode.
That's correct.
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Updated•12 years ago
|
Blocks: ReleaseDownloadsPane
|
||
Comment 7•12 years ago
|
||
Verified as fixed on the latest Nightly - the in-content downloads view shows only the downloads that were made while in Private Browsing mode.
Verified on Windows 7, Ubuntu 12.10 and Mac OS X 10.8.2:
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20130102 Firefox/20.0 Build ID: 20130102030907
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130103 Firefox/20.0 Build ID: 20130103030946
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20130103 Firefox/20.0 Build ID: 20130103030946
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•