Using may24 commercial trunk build Offline UI spec: http://www.mozilla.org/mailnews/specs/ Both the Work Offline and Work Online dialogs should have default selections, they currently don't. 1. The Work Offline dialog should have: a. "Always ask me..." checkbox enabled b. Download button selected as default 2. The Work Online dialog should have: a. "Always ask me..." checkbox enabled b. "Send" button selected as default

Reminder: make the "Always ask me" checkbox tie in with the prefs panel to disable the associated ask me pref if user unchecks the ask me option in the Work Online/Offline dialogs.

taking ..

PDT+ per 6/12 mtg.

cc'ing bhuvan for review & spitzer for super review;

Changes look good to me. However, there seems to be a lot of common code among these files. Please optimize the code in 093 timeframe. Indentation needs to he fixed here and there. Please comment as to what does various values for the following pref actually means. "offline.download.download_messages", 1 Also, add comments in general to the routines & other notable statements. Please do post screenshots with default selections. bhuvan

Is it possible to have some space between the dialog question and the "Always ask me..." checkbox? And also between the checkbox and the buttons at the bottom? The whole dialog (both of them) just looks squished together. Also, the dialogs are sort of wide horizontally. Maybe the text could wrap to the next line to keep them less wide.

Mohan, can you please try and use nsIPrompt or nsICommonDialogs to display common dialogs like this? There is no point of emulating that component like you do. Not only is the nsIPrompt/nsICommonDialogs code reusable, but a lot of the code you are adding in this release of your patch already exists in dialogOverlay.

bug # 79865 has the combined patch;

pushing out. 0.9.2 is done. (querying for this string will get you the list of the 0.9.2 bugs I moved to 0.9.3)

Removing PDT+, marking nsbranch; should be checked into the 0.9.3 trunk ASAP, tested & verified, then submitted for limbo builds.

Fix checked in on behalf on mohanb.

Adding vtrunk; bugs need to be verified in the trunk for eventual limbo checkins.

Clearing resolution, nsBranch bugs should be closed only after checkins into limbo builds.

Commercial builds 2001-07-05-09-trunk/ win nt 4.0 2001-07-05-08-trunk/ linux 2.2, red hat 7.0 2001-07-05-08-trunk/ mac os 9.0.4 Verified the following: -When going offline this appears: 1. The Work Offline dialog should have: a. "Always ask me..." checkbox is enabled b. Download button selected as default -When going online this appears: 2. The Work Online dialog should have: a. "Always ask me..." checkbox is enabled b. "Send" button selected as default -Doing the following scenarios results in these prefs being set * Work Offline dialog -Uncheck "Always ask me" and hit download button it results in Edit|Pref|Offline and Disk Space|Automatically download my messages for offline use is set -Uncheck "Always ask me" and hit don't download button it results in Edit|Pref|Offline and Disk Space|Do Not download my messages for offline use is set -leave the "Always ask me" checked in download/don't download or send/don't send will result in the 'ask me pref' in Edit|Pref|Offline and Disk Space|Ask me being set Verified on trunk. Removing Keyword Vtrunk. adding 'verified on trunk' to status whiteboard. Leaving status as Assigned per instructions from Jussi.

Missed 0.9.3.

changing the resolution to fixed, since it is checked into the trunk;

Verified with Commercial builds: 2001082809 - win nt 4.0 2001082808 - linux 2.2, mac 9.0.4 1. The Work Offline dialog has: a. "Always ask me..." checkbox enabled b. Download button selected as default 2. The Work Online dialog has: a. "Always ask me..." checkbox enabled b. "Send" button selected as default Preference Panel's "Offline & Disk Space" options are set properly with the following combinations: When going offline: 1. Uncheck "Always ask me..." and hit download button result in "Automatically download messages for offline use" option is set. 2. Uncheck "Always ask me..." and hit Don't download button result in "Do not download messages for offline use" option is set. 3. Check "Always ask me..." and hit download button result in "Ask me if I want to download messages..." option is set. 4. Check "Always ask me..." and hit Don't download button result in "Ask me if I want to download messages..." option is set. When going online: 1. Uncheck "Always ask me..." and hit Send button result in "Automatically send my unsent messages" option is set. 2. Uncheck "Always ask me..." and hit Don't Send button result in "Do not send my unsent messages" option is set. 3. Check "Always ask me..." and hit Send button result in "Ask me if I want to send my unsent messages" option is set. 4. Check "Always ask me..." and hit Don't Send button result in "Ask me if I want to send my unsent messages" option is set. Gary, I don't have the privelege to change the bug's status field, can you mark the bug as Verified for me? thx.

Marking verified.