Jared Wein [:jaws] (please needinfo? me) Reporter
	Description • 12 years ago

I don't have great steps to reproduce, but this seems to happen only with the click-to-play notifications. To turn those on, go to about:config and set plugins.click_to_play=true, then visit sites that use plugins.

When this happens, the little arrow shows in the location bar, but doesn't show the icon. Clicking on the arrow will then cause the rest of the notification icon to show.

I've attached a screenshot of what it looks like before clicking on it.

	Wesley Johnston (:wesj)
	Comment 1 • 12 years ago

I can see something like this on cnn.com by loading cnn.com in one tab, and then right clicking to load a story from the "This Just In" section in a background tab. I'm guessing that the UI is misinterpreting a message from the background tab?

	Paul Silaghi, QA [:pauly]
	Comment 2 • 12 years ago

STR:
1. Have 2 tabs CTP blocked, CTP icon present in each tab
2. Reload first tab
3. Quickly switch to the second tab (before first tab finishes reloading)

AR: CTP icon disappears

	Georg Fritzsche [:gfritzsche]
	Comment 4 • 12 years ago

Still occuring. Switching tabs again fixes it.

	Georg Fritzsche [:gfritzsche]
	Comment 5 • 12 years ago

Not happening with the camera permission notification, so this might be specific to the CtP notification implementation.

	Randell Jesup [:jesup] (needinfo me)
	Comment 6 • 12 years ago

Now being seen in Camera/mic notifications (not sure if it's a regression there due to changing the implementation, or was just noticed and has always been there).  See bug 847180

	Jason Smith [:jsmith]
	Comment 8 • 12 years ago

Given that CTP has shipped and had this bug, I don't think the gUM equivalent version of this bug blocks. However, based on the discussion on the associated dupe, this is still a really important bug to fix (also known as: a strong want, but not blocking).

Let's track this for Firefox 21. We can probably ship with this bug on gUM then for FF 20, so no need to go sprinting to land this on Beta unless the patch is extremely low risk.

	Jason Smith [:jsmith]
	Comment 9 • 12 years ago

Might be worth rel noting this too for FF 20.

	Dão Gottwald [:dao] Assignee
	Comment 10 • 12 years ago

Has somebody looked whether this is a regression? Are notifications other than click-to-play and getUserMedia affected?

	Paul Silaghi, QA [:pauly]
	Comment 11 • 12 years ago

This is not a regression in CTP - reproducible on FF 16, 17.
Can you give an example of other notifications to test ?

	Dão Gottwald [:dao] Assignee
	Comment 12 • 12 years ago

(In reply to Paul Silaghi [QA] from comment #11)
> Can you give an example of other notifications to test ?

geolocation and addon installation

	Paul Silaghi, QA [:pauly]
	Comment 13 • 12 years ago

(In reply to Dão Gottwald [:dao] from comment #12)
> geolocation and addon installation
both are affected

and it seems to be a regression:
Last good nightly: 2012-05-04
First bad nightly: 2012-05-05

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2db9df42823d&tochange=0a48e6561534

	Jared Wein [:jaws] (please needinfo? me) Reporter
	Comment 14 • 12 years ago

Likely cause from pushlog:
OHZEKI Tetsuharu — Bug 641892 - Support showing multiple popup notification icons at the same time. r=margaret

	Jason Smith [:jsmith]
	Comment 15 • 12 years ago

Hmm...if the bug has been around for that long and people aren't yelling about this, then it probably isn't critical track then. But we should definitely push for a fix here.

	Jared Wein [:jaws] (please needinfo? me) Reporter
	Comment 16 • 12 years ago

(In reply to Jason Smith [:jsmith] from comment #15)
> Hmm...if the bug has been around for that long and people aren't yelling
> about this, then it probably isn't critical track then.

The level of noise is most likely due to the fact that many of these notifications are rare in their appearance in the first place.

The most visible notification pre-CTP is the remember-password notification. This notification usually only appears after a user has entered their password and hit submit on a form, meaning that the user is actively engaging with the tab.

The easiest way to reproduce this bug is to load pages in multiple/background tabs which is highly likely to trigger a CTP notification, but not many other notifications.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 18 • 12 years ago

Comment on attachment 722212 [details] [diff] [review]
patch

Couldn't you more efficiently check notification.browser == this.tabbrowser.selectedBrowser?

Seems like we need a test for this.

r=me with those addressed.

	Dão Gottwald [:dao] Assignee
	Comment 20 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/e25ca1ca1f17

	Ryan VanderMeulen [:RyanVM]
	Comment 21 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/e25ca1ca1f17

	Dão Gottwald [:dao] Assignee
	Comment 22 • 12 years ago

Comment on attachment 722842 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 641892
User impact if declined: missing notification icons for frequent popup notifications such as click to play
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

	Dão Gottwald [:dao] Assignee
	Comment 23 • 12 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/53629e60482e

	u279076
	Comment 24 • 12 years ago

Does this need QA verification given in-testsuite coverage?

	Paul Silaghi, QA [:pauly]
	Comment 25 • 12 years ago

Verified fixed Aurora 21.0a2 (2013-03-17), Nightly 22.0a1 (2013-03-17) on Win 7, Ubuntu 12.04, Mac 10.7.5.

	Alex Keybl [:akeybl]
	Comment 26 • 11 years ago

Without easily reproducible STR, or significant user feedback around this issue, it'll be difficult/unnecessary to relnote.

	Jason Smith [:jsmith]
	Comment 27 • 11 years ago

(In reply to Alex Keybl [:akeybl] from comment #26)
> Without easily reproducible STR, or significant user feedback around this
> issue, it'll be difficult/unnecessary to relnote.

There's reproducible STR in the associated dupe on this bug.