Closed
Bug 826032
Opened 12 years ago
Closed 12 years ago
add debugging statements to talos when we add windows counters
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
To battle against our never ending problem of missing counters, I want to fix the non xperf counters now, then solve the xperf ones in the near future.
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 697161 [details] [diff] [review]
add print statements to help debug what is going on with our missing windows counters (1.0)
The print statements should probably be utils.noisy statements. That said, we already have these in both forms all over the code so it really doesn't matter
Attachment #697161 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•12 years ago
|
||
there are more statements we need to look at.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #698047 -
Flags: review?(jhammel)
Assignee | ||
Comment 6•12 years ago
|
||
oh typos
Attachment #698047 -
Attachment is obsolete: true
Attachment #698047 -
Flags: review?(jhammel)
Attachment #698053 -
Flags: review?(jhammel)
Assignee | ||
Comment 7•12 years ago
|
||
and another one, this should be final
Attachment #698053 -
Attachment is obsolete: true
Attachment #698053 -
Flags: review?(jhammel)
Attachment #698056 -
Flags: review?(jhammel)
Comment 8•12 years ago
|
||
Comment on attachment 698056 [details] [diff] [review]
investigate exception around win32 counters (1.2)
r+ contingent on removing the talosDebug parts of the string. we should not do structured logging by replicating a string many places as this is error-prone and annoying to cleanup
Attachment #698056 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 9•12 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•