Closed Bug 826032 Opened 12 years ago Closed 12 years ago

add debugging statements to talos when we add windows counters

Categories

(Testing :: Talos, defect)

All
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(2 files, 2 obsolete files)

To battle against our never ending problem of missing counters, I want to fix the non xperf counters now, then solve the xperf ones in the near future.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #697161 - Flags: review?(jhammel)
Comment on attachment 697161 [details] [diff] [review] add print statements to help debug what is going on with our missing windows counters (1.0) The print statements should probably be utils.noisy statements. That said, we already have these in both forms all over the code so it really doesn't matter
Attachment #697161 - Flags: review?(jhammel) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 826042
there are more statements we need to look at.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #698047 - Flags: review?(jhammel)
oh typos
Attachment #698047 - Attachment is obsolete: true
Attachment #698047 - Flags: review?(jhammel)
Attachment #698053 - Flags: review?(jhammel)
and another one, this should be final
Attachment #698053 - Attachment is obsolete: true
Attachment #698053 - Flags: review?(jhammel)
Attachment #698056 - Flags: review?(jhammel)
Comment on attachment 698056 [details] [diff] [review] investigate exception around win32 counters (1.2) r+ contingent on removing the talosDebug parts of the string. we should not do structured logging by replicating a string many places as this is error-prone and annoying to cleanup
Attachment #698056 - Flags: review?(jhammel) → review+
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: